Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Update method under ATOM Management Client #9379

Closed
HarshaNalluru opened this issue Jun 8, 2020 · 4 comments
Closed

[Service Bus] Update method under ATOM Management Client #9379

HarshaNalluru opened this issue Jun 8, 2020 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone

Comments

@HarshaNalluru
Copy link
Member

Update method allows only a subset of parameters from QueueDescription to be changed, users may get confused by not knowing which ones are updatable.
Should we consider a new options bag for the update method?

https://docs.microsoft.com/en-us/rest/api/servicebus/update-queue

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 8, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Jun 9, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 9, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] July milestone Jun 9, 2020
@HarshaNalluru
Copy link
Member Author

Two problems with update requests..

  • Default values would override if only a subset of properties of QueueDescription are provided in the request
  • The update request with only a subset of attributes from QueueDescription would result in a response that doesn't contain all the attributes from QueueDescription(partial QueueDescription)

Above problems can be avoided by

  • Telling users to make a get request before an update request.
    OR
  • Doing a get request before update at the SDK level.

@HarshaNalluru
Copy link
Member Author

HarshaNalluru commented Jun 18, 2020

Final Proposal

  • Service returns meaningful error when tried to update something that cannot be updated
  • Have user do a GET/CREATE, tweak what needs to be updated, pass it to UPDATE
  • Throw error if the input is partial
  • Consider adding Etag to the response and pass it to the update request to make sure no other updates have happened in between

@HarshaNalluru
Copy link
Member Author

HarshaNalluru commented Jun 26, 2020

Questions:

@ramya-rao-a
Copy link
Contributor

Closing with #9751
Let's log a separate issue for investigating etag use in update operations

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants