Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimisticConcurrencyViaEtag.ts does not update on the existing configuration setting #9450

Closed
2 of 6 tasks
AndreasHassing opened this issue Jun 10, 2020 · 1 comment · Fixed by #9451
Closed
2 of 6 tasks

optimisticConcurrencyViaEtag.ts does not update on the existing configuration setting #9450

AndreasHassing opened this issue Jun 10, 2020 · 1 comment · Fixed by #9451
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@AndreasHassing
Copy link
Contributor

  • Package Name: master
  • Package Version: master
  • Operating system:
  • nodejs
    • version: v12.16.3
  • browser
    • name/version:
  • typescript
    • version: 3.6.5
  • Is the bug related to documentation in

Describe the bug
The sample in optimisticConcurrencyViaEtag.ts doesn't do what you'd expect, because it is not trying to update the previously fetched configuration value - it just updates directly on the key; i.e. not optimistic concurrency.

To Reproduce
Steps to reproduce the behavior:

  1. Run the sample.

Actual behavior
The sample succeeds when updating Alpha.

Expected behavior
The sample "fails" when updating Alpha.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Jun 10, 2020
@AndreasHassing AndreasHassing mentioned this issue Jun 10, 2020
Merged
@AndreasHassing
Copy link
Contributor Author

Added PR for closing.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sample optimisticConcurrencyViaEtag
1 participant
@AndreasHassing