Skip to content

Commit 02a7753

Browse files
Copilotlive1206
andcommitted
Address review feedback: rename csproj, remove Directory.Build.props, reorder package.json, update launchSettings.json, fix lint issues
Co-authored-by: live1206 <5196139+live1206@users.noreply.github.com>
1 parent 9f002db commit 02a7753

File tree

7 files changed

+32
-16
lines changed

7 files changed

+32
-16
lines changed

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Properties/launchSettings.json

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,35 @@
11
{
22
"profiles": {
3+
"http-azure-resource-manager-common-properties": {
4+
"commandLineArgs": "$(SolutionDir)/../dist/generator/Microsoft.TypeSpec.Generator.dll $(SolutionDir)/TestProjects/Spector/http/azure/resource-manager/common-properties -g MgmtStubGenerator",
5+
"commandName": "Executable",
6+
"executablePath": "dotnet"
7+
},
8+
"http-azure-resource-manager-large-header": {
9+
"commandLineArgs": "$(SolutionDir)/../dist/generator/Microsoft.TypeSpec.Generator.dll $(SolutionDir)/TestProjects/Spector/http/azure/resource-manager/large-header -g MgmtStubGenerator",
10+
"commandName": "Executable",
11+
"executablePath": "dotnet"
12+
},
13+
"http-azure-resource-manager-method-subscription-id": {
14+
"commandLineArgs": "$(SolutionDir)/../dist/generator/Microsoft.TypeSpec.Generator.dll $(SolutionDir)/TestProjects/Spector/http/azure/resource-manager/method-subscription-id -g MgmtStubGenerator",
15+
"commandName": "Executable",
16+
"executablePath": "dotnet"
17+
},
18+
"http-azure-resource-manager-non-resource": {
19+
"commandLineArgs": "$(SolutionDir)/../dist/generator/Microsoft.TypeSpec.Generator.dll $(SolutionDir)/TestProjects/Spector/http/azure/resource-manager/non-resource -g MgmtStubGenerator",
20+
"commandName": "Executable",
21+
"executablePath": "dotnet"
22+
},
23+
"http-azure-resource-manager-operation-templates": {
24+
"commandLineArgs": "$(SolutionDir)/../dist/generator/Microsoft.TypeSpec.Generator.dll $(SolutionDir)/TestProjects/Spector/http/azure/resource-manager/operation-templates -g MgmtStubGenerator",
25+
"commandName": "Executable",
26+
"executablePath": "dotnet"
27+
},
28+
"http-azure-resource-manager-resources": {
29+
"commandLineArgs": "$(SolutionDir)/../dist/generator/Microsoft.TypeSpec.Generator.dll $(SolutionDir)/TestProjects/Spector/http/azure/resource-manager/resources -g MgmtStubGenerator",
30+
"commandName": "Executable",
31+
"executablePath": "dotnet"
32+
},
333
"Mgmt-TypeSpec": {
434
"commandLineArgs": "$(SolutionDir)/../dist/generator/Microsoft.TypeSpec.Generator.dll $(SolutionDir)/TestProjects/Local/Mgmt-TypeSpec -g MgmtClientGenerator",
535
"commandName": "Executable",
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
</PropertyGroup>
77

88
<ItemGroup>
9-
<PackageReference Include="Azure.Core" />
10-
<PackageReference Include="Azure.ResourceManager" />
119
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" />
1210
<PackageReference Include="NUnit" />
1311
<PackageReference Include="NUnit3TestAdapter" />

eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector.Tests/Infrastructure/SpectorModelTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,5 @@ public void ThrowsIfUnknownFormat()
5151
[SpectorTest]
5252
public void ThrowsIfWireIsNotJson()
5353
=> ThrowsIfWireIsNotJsonBase();
54-
5554
}
5655
}

eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector.Tests/Infrastructure/TestServerBase.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public TestServerBase(string processPath, string processArguments)
4141
var s = _process.StandardOutput.ReadLine();
4242
var indexOfPort = s?.IndexOf(portPhrase);
4343
if (indexOfPort > 0)
44-
{
44+
{
4545
Port = s!.Substring(indexOfPort.Value + portPhrase.Length).Trim();
4646
Host = new Uri($"http://localhost:{Port}");
4747
Client = new HttpClient

eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector.Tests/SpectorTestBase.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ public async Task Test(Func<Uri, Task> test)
5656
=> InvokeMethodInternal(obj.GetType(), obj, methodName, [],
5757
BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Public, args);
5858

59-
6059
private static object? InvokeMethodInternal(Type type,
6160
object obj,
6261
string methodName,

eng/packages/http-client-csharp-mgmt/generator/TestProjects/Spector/Directory.Build.props

Lines changed: 0 additions & 10 deletions
This file was deleted.

eng/packages/http-client-csharp-mgmt/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@
5555
"@typespec/http-specs": "0.1.0-alpha.28",
5656
"@typespec/openapi": "1.6.0",
5757
"@typespec/rest": "0.76.0",
58-
"@typespec/streams": "0.76.0",
5958
"@typespec/spec-api": "0.1.0-alpha.10",
6059
"@typespec/spector": "0.1.0-alpha.20",
60+
"@typespec/streams": "0.76.0",
6161
"@typespec/tspd": "0.73.1",
6262
"@typespec/versioning": "0.76.0",
6363
"@typespec/xml": "0.76.0",

0 commit comments

Comments
 (0)