Skip to content

Commit 70f9c17

Browse files
committed
Fix unittests and the AOT compatibility.
1 parent f8653fa commit 70f9c17

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

sdk/ai/Azure.AI.Agents/src/Custom/Internal/AdditionalPropertyHelpers.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
using System;
77
using System.ClientModel.Primitives;
88
using System.Collections.Generic;
9+
using System.Diagnostics.CodeAnalysis;
910
using System.Reflection;
1011

1112
#pragma warning disable OPENAI001
@@ -14,7 +15,7 @@ namespace Azure.AI.Agents;
1415

1516
internal static partial class AdditionalPropertyHelpers
1617
{
17-
internal static void SetAdditionalProperty<T, U>(this T instance, string key, U value)
18+
internal static void SetAdditionalProperty<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.NonPublicProperties)]T, U>(this T instance, string key, U value)
1819
where T : IJsonModel<T>
1920
{
2021
PropertyInfo additionalDataProperty = instance.GetType().GetProperty("SerializedAdditionalRawData", BindingFlags.Instance | BindingFlags.NonPublic);
@@ -31,7 +32,7 @@ internal static void SetAdditionalProperty<T, U>(this T instance, string key, U
3132
additionalDataProperty.SetValue(instance, additionalData);
3233
}
3334

34-
internal static U GetAdditionalProperty<T, U>(this T instance, string key)
35+
internal static U GetAdditionalProperty<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.NonPublicProperties)] T, U>(this T instance, string key)
3536
{
3637
PropertyInfo additionalDataProperty = instance.GetType().GetProperty("SerializedAdditionalRawData", BindingFlags.Instance | BindingFlags.NonPublic);
3738
object existingSerializedAdditionalRawData = additionalDataProperty.GetValue(instance);

sdk/ai/Azure.AI.Agents/src/Custom/Internal/PipelinePolicyHelpers.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,12 @@ public static void AddAzureFinetuningParityPolicy(OpenAIClientOptions options)
199199
"Content-Disposition: form-data; name=file; filename=([^;]*);.*") is Match fileContentDispositionMatch
200200
&& fileContentDispositionMatch.Success)
201201
{
202-
newRequestWriter.WriteLine("Content-Type: application/octet-stream");
202+
// We are explicitly set the line ending as
203+
// WriteLine will add only \n symbol on Unix systems,
204+
// Which will result in error 400 on te service side.
205+
newRequestWriter.Write("Content-Type: application/octet-stream\r\n");
203206
}
204-
newRequestWriter.WriteLine(line);
207+
newRequestWriter.Write($"{line}\r\n");
205208
previousLine = line;
206209
}
207210

0 commit comments

Comments
 (0)