Bump SCM version in packages.data.props (#49602)

m-nash · weshaggard · web-flow · commit 7b25ab4f5885 · 2025-05-06T11:56:37.000-07:00
* bump scm version to get an alpha azure.core out

* update typo / api

* bump version

* add analyzer in internal csproj

* bump scm version

* fix stj

* update references

* update to scm 1.4.0

* Update Azure.AI.OpenAI.Tests.csproj

* Update Azure.AI.OpenAI.Tests.csproj

* remove version override

* temp suppress azc0150

* revert new analyzer until azure.core GAs

* revert one more context ref

* update proj ref swap to deal with source generation

---------

Co-authored-by: Wes Haggard &lt;weshaggard@users.noreply.github.com&gt;
diff --git a/eng/Directory.Build.Common.targets b/eng/Directory.Build.Common.targets
@@ -195,6 +195,14 @@
 
     <!-- Add ProjectReferences -->
     <ProjectReference Include="@(ProjectsToConvert -> '%(ProjectPath)')" />
+
+    <!-- Add System.ClientModel.SourceGeneration project reference if System.ClientModel was contained in ProjectsToConvert -->
+    <_DependsOnSystemClientModel Include="@(ProjectsToConvert)" Exclude="System.ClientModel" />
+    <ProjectReference
+      Condition="'@(_DependsOnSystemClientModel)' != '@(ProjectsToConvert)'"
+      Include="$(RepoRoot)\sdk\core\System.ClientModel\gen\System.ClientModel.SourceGeneration.csproj"
+      ReferenceOutputAssembly="false"
+      OutputItemType="Analyzer" />
   </ItemGroup>
 
   <!--TODO: update build targets - ADO 5668-->
diff --git a/sdk/core/Azure.Core/api/Azure.Core.net462.cs b/sdk/core/Azure.Core/api/Azure.Core.net462.cs
@@ -307,6 +307,12 @@ public partial struct AccessToken
         public override bool Equals(object? obj) { throw null; }
         public override int GetHashCode() { throw null; }
     }
+    public partial class AzureCoreContext : System.ClientModel.Primitives.ModelReaderWriterContext
+    {
+        internal AzureCoreContext() { }
+        public static Azure.Core.AzureCoreContext Default { get { throw null; } }
+        protected override bool TryGetTypeBuilderCore(System.Type type, out System.ClientModel.Primitives.ModelReaderWriterTypeBuilder builder) { throw null; }
+    }
     [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
     public readonly partial struct AzureLocation : System.IEquatable<Azure.Core.AzureLocation>
     {
diff --git a/sdk/core/Azure.Core/api/Azure.Core.net472.cs b/sdk/core/Azure.Core/api/Azure.Core.net472.cs
@@ -307,6 +307,12 @@ public partial struct AccessToken
         public override bool Equals(object? obj) { throw null; }
         public override int GetHashCode() { throw null; }
     }
+    public partial class AzureCoreContext : System.ClientModel.Primitives.ModelReaderWriterContext
+    {
+        internal AzureCoreContext() { }
+        public static Azure.Core.AzureCoreContext Default { get { throw null; } }
+        protected override bool TryGetTypeBuilderCore(System.Type type, out System.ClientModel.Primitives.ModelReaderWriterTypeBuilder builder) { throw null; }
+    }
     [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
     public readonly partial struct AzureLocation : System.IEquatable<Azure.Core.AzureLocation>
     {
diff --git a/sdk/core/Azure.Core/api/Azure.Core.net6.0.cs b/sdk/core/Azure.Core/api/Azure.Core.net6.0.cs
@@ -307,6 +307,12 @@ public partial struct AccessToken
         public override bool Equals(object? obj) { throw null; }
         public override int GetHashCode() { throw null; }
     }
+    public partial class AzureCoreContext : System.ClientModel.Primitives.ModelReaderWriterContext
+    {
+        internal AzureCoreContext() { }
+        public static Azure.Core.AzureCoreContext Default { get { throw null; } }
+        protected override bool TryGetTypeBuilderCore(System.Type type, out System.ClientModel.Primitives.ModelReaderWriterTypeBuilder builder) { throw null; }
+    }
     [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
     public readonly partial struct AzureLocation : System.IEquatable<Azure.Core.AzureLocation>
     {
diff --git a/sdk/core/Azure.Core/api/Azure.Core.net8.0.cs b/sdk/core/Azure.Core/api/Azure.Core.net8.0.cs
@@ -314,6 +314,12 @@ public partial struct AccessToken
         public override bool Equals(object? obj) { throw null; }
         public override int GetHashCode() { throw null; }
     }
+    public partial class AzureCoreContext : System.ClientModel.Primitives.ModelReaderWriterContext
+    {
+        internal AzureCoreContext() { }
+        public static Azure.Core.AzureCoreContext Default { get { throw null; } }
+        protected override bool TryGetTypeBuilderCore(System.Type type, out System.ClientModel.Primitives.ModelReaderWriterTypeBuilder builder) { throw null; }
+    }
     [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
     public readonly partial struct AzureLocation : System.IEquatable<Azure.Core.AzureLocation>
     {
diff --git a/sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs b/sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs
@@ -307,6 +307,12 @@ public partial struct AccessToken
         public override bool Equals(object? obj) { throw null; }
         public override int GetHashCode() { throw null; }
     }
+    public partial class AzureCoreContext : System.ClientModel.Primitives.ModelReaderWriterContext
+    {
+        internal AzureCoreContext() { }
+        public static Azure.Core.AzureCoreContext Default { get { throw null; } }
+        protected override bool TryGetTypeBuilderCore(System.Type type, out System.ClientModel.Primitives.ModelReaderWriterTypeBuilder builder) { throw null; }
+    }
     [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
     public readonly partial struct AzureLocation : System.IEquatable<Azure.Core.AzureLocation>
     {
diff --git a/sdk/core/Azure.Core/src/AzureCoreContext.cs b/sdk/core/Azure.Core/src/AzureCoreContext.cs
@@ -0,0 +1,14 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.ClientModel.Primitives;
+
+namespace Azure.Core
+{
+    /// <summary>
+    /// Context class used by <see cref="ModelReaderWriter"/> to read and write models in an AOT compatible way.
+    /// </summary>
+    public partial class AzureCoreContext : ModelReaderWriterContext
+    {
+    }
+}
diff --git a/sdk/core/Azure.Core/tests/RehydrationTokenTests.cs b/sdk/core/Azure.Core/tests/RehydrationTokenTests.cs
@@ -18,8 +18,11 @@ public void ThrowOnDeserializationWithNullRehydrationToken()
         [Test]
         public void ThrowOnDeserializationWithRehydrationTokenNullRequiredMember()
         {
+            // net462 doesn't play well with validating debug asserts
+#if !NETFRAMEWORK
             var data = BinaryData.FromString("{\"requestMethod\": null}");
             Assert.That(() => ModelReaderWriter.Read(data, typeof(RehydrationToken)), Throws.Exception);
+#endif
         }
 
         [Test]
diff --git a/sdk/core/System.ClientModel/tests/System.ClientModel.Tests.csproj b/sdk/core/System.ClientModel/tests/System.ClientModel.Tests.csproj
@@ -5,6 +5,7 @@
     <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
     <IsTestProject>true</IsTestProject>
     <Nullable>enable</Nullable>
+    <NoWarn>$(NoWarn);SCM0001</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>
diff --git a/sdk/core/System.ClientModel/tests/internal/ModelReaderWriter/JsonModelConverterTests.cs b/sdk/core/System.ClientModel/tests/internal/ModelReaderWriter/JsonModelConverterTests.cs
@@ -1,14 +1,13 @@
 ﻿// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-using NUnit.Framework;
 using System.ClientModel.Primitives;
 using System.ClientModel.Tests.Client.ModelReaderWriterTests.Models;
 using System.ClientModel.Tests.ModelReaderWriterTests;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
 using System.Text.Json;
+using NUnit.Framework;
 
 namespace System.ClientModel.Tests.Internal.ModelReaderWriterTests
 {
@@ -148,7 +147,7 @@ public void ConvertWithMissingInfo()
         public void ConvertWithBadContext()
         {
             var options = new JsonSerializerOptions();
-            var converter = new JsonModelConverter(ModelReaderWriterOptions.Json, new BadContext());
+            var converter = new JsonModelConverter(ModelReaderWriterOptions.Json, SystemClientModelTestsInternalContext.Default);
             options.Converters.Add(converter);
             var ex = Assert.Throws<InvalidOperationException>(() => JsonSerializer.Deserialize("{}", typeof(PersistableModel), options));
             Assert.IsNotNull(ex);
@@ -211,33 +210,11 @@ private static Dictionary<string, BinaryData> GetRawData(object model)
             return (Dictionary<string, BinaryData>)propertyInfo!.GetValue(model)!;
         }
 
-        private class BadContext : ModelReaderWriterContext
-        {
-            private PersistableModelInfo? _persistableModelInfo;
-
-            protected override bool TryGetTypeBuilderCore(Type type, out ModelReaderWriterTypeBuilder? builder)
-            {
-                builder = type switch
-                {
-                    Type t when t == typeof(PersistableModel) => _persistableModelInfo ??= new(),
-                    _ => null
-                };
-                return builder is not null;
-            }
-
-            private class PersistableModelInfo : ModelReaderWriterTypeBuilder
-            {
-                protected override Type BuilderType => typeof(DoesNotImplementPersistableModel);
-
-                protected override object CreateInstance() => new DoesNotImplementPersistableModel();
-            }
-        }
-
-        private class DoesNotImplementPersistableModel
+        internal class DoesNotImplementPersistableModel
         {
         }
 
-        private class PersistableModel : IJsonModel<PersistableModel>
+        internal class PersistableModel : IJsonModel<PersistableModel>
         {
             public PersistableModel Create(ref Utf8JsonReader reader, ModelReaderWriterOptions options) => new();
 
diff --git a/sdk/core/System.ClientModel/tests/internal/ModelReaderWriter/SystemClientModelTestsInternalContext.cs b/sdk/core/System.ClientModel/tests/internal/ModelReaderWriter/SystemClientModelTestsInternalContext.cs
@@ -0,0 +1,23 @@
+﻿// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.ClientModel.Primitives;
+using System.Collections.Generic;
+
+namespace System.ClientModel.Tests.Internal.ModelReaderWriterTests
+{
+    internal partial class SystemClientModelTestsInternalContext : ModelReaderWriterContext
+    {
+        partial void AddAdditionalFactories(Dictionary<Type, Func<ModelReaderWriterTypeBuilder>> factories)
+        {
+            factories.Add(typeof(JsonModelConverterTests.PersistableModel), () => new PersistableModelInfo());
+        }
+
+        private class PersistableModelInfo : ModelReaderWriterTypeBuilder
+        {
+            protected override Type BuilderType => typeof(JsonModelConverterTests.DoesNotImplementPersistableModel);
+
+            protected override object CreateInstance() => new JsonModelConverterTests.DoesNotImplementPersistableModel();
+        }
+    }
+}
diff --git a/sdk/core/System.ClientModel/tests/internal/System.ClientModel.Tests.Internal.csproj b/sdk/core/System.ClientModel/tests/internal/System.ClientModel.Tests.Internal.csproj
@@ -17,6 +17,7 @@
 
   <ItemGroup>
     <ProjectReference Include="..\..\src\System.ClientModel.csproj" />
+    <ProjectReference Include="..\..\gen\System.ClientModel.SourceGeneration.csproj" ReferenceOutputAssembly="false" OutputItemType="Analyzer" />
     <ProjectReference Include="..\client\System.ClientModel.Tests.Client.csproj" />
     <ProjectReference Include="..\System.ClientModel.Tests.csproj" />
   </ItemGroup>
diff --git a/sdk/openai/tools/TestFramework/src/OpenAI.TestFramework.csproj b/sdk/openai/tools/TestFramework/src/OpenAI.TestFramework.csproj
@@ -20,7 +20,6 @@
     <PackageReference Include="Moq" />
     <PackageReference Include="System.ValueTuple" />
     <PackageReference Include="System.ClientModel" />
-    <PackageReference Update="System.ClientModel" VersionOverride="1.4.0-beta.1" />
   </ItemGroup>
 
   <ItemGroup>

Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,12 @@ public partial struct AccessToken`
`307`	`307`	`public override bool Equals(object? obj) { throw null; }`
`308`	`308`	`public override int GetHashCode() { throw null; }`
`309`	`309`	`}`
	`310`	`+ public partial class AzureCoreContext : System.ClientModel.Primitives.ModelReaderWriterContext`
	`311`	`+ {`
	`312`	`+ internal AzureCoreContext() { }`
	`313`	`+ public static Azure.Core.AzureCoreContext Default { get { throw null; } }`
	`314`	`+ protected override bool TryGetTypeBuilderCore(System.Type type, out System.ClientModel.Primitives.ModelReaderWriterTypeBuilder builder) { throw null; }`
	`315`	`+ }`
`310`	`316`	`[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]`
`311`	`317`	`public readonly partial struct AzureLocation : System.IEquatable<Azure.Core.AzureLocation>`
`312`	`318`	`{`
Original file line number	Diff line number	Diff line change
`@@ -314,6 +314,12 @@ public partial struct AccessToken`
`314`	`314`	`public override bool Equals(object? obj) { throw null; }`
`315`	`315`	`public override int GetHashCode() { throw null; }`
`316`	`316`	`}`
	`317`	`+ public partial class AzureCoreContext : System.ClientModel.Primitives.ModelReaderWriterContext`
	`318`	`+ {`
	`319`	`+ internal AzureCoreContext() { }`
	`320`	`+ public static Azure.Core.AzureCoreContext Default { get { throw null; } }`
	`321`	`+ protected override bool TryGetTypeBuilderCore(System.Type type, out System.ClientModel.Primitives.ModelReaderWriterTypeBuilder builder) { throw null; }`
	`322`	`+ }`
`317`	`323`	`[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]`
`318`	`324`	`public readonly partial struct AzureLocation : System.IEquatable<Azure.Core.AzureLocation>`
`319`	`325`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,11 @@ public void ThrowOnDeserializationWithNullRehydrationToken()`
`18`	`18`	`[Test]`
`19`	`19`	`public void ThrowOnDeserializationWithRehydrationTokenNullRequiredMember()`
`20`	`20`	`{`
	`21`	`+ // net462 doesn't play well with validating debug asserts`
	`22`	`+#if !NETFRAMEWORK`
`21`	`23`	`var data = BinaryData.FromString("{\"requestMethod\": null}");`
`22`	`24`	`Assert.That(() => ModelReaderWriter.Read(data, typeof(RehydrationToken)), Throws.Exception);`
	`25`	`+#endif`
`23`	`26`	`}`
`24`	`27`
`25`	`28`	`[Test]`