Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure.Search: Ensure input and output document order is in sync while batching #10593

Closed
tg-msft opened this issue Mar 13, 2020 · 4 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone

Comments

@tg-msft
Copy link
Member

tg-msft commented Mar 13, 2020

We need to add (performant) checks that the document order is maintained so customers can just index into the results safely.

@tg-msft tg-msft added Client This issue points to a problem in the data-plane of the library. Search labels Mar 13, 2020
@tg-msft tg-msft self-assigned this Mar 13, 2020
@tg-msft tg-msft modified the milestones: apri, [2020] April Mar 19, 2020
@tg-msft tg-msft modified the milestones: [2020] April, [2020] May Apr 6, 2020
@AlexGhiondea
Copy link
Contributor

Do we know if this is supported by the service already (ie. is there already an expectation that the documents will come out in the same order?)

@brjohnstmsft
Copy link
Member

@AlexGhiondea It may work by accident, but it's not part of our public contract so there's no guarantee.

@tg-msft
Copy link
Member Author

tg-msft commented Jun 9, 2020

Moving to the backlog because we don't have enough information today to determine the "key" column of a document. We might at some point in the future when we add FieldBuilder. Until then folks will have to map string Key to their documents by hand if they want to be paranoid about response ordering.

@AlexGhiondea
Copy link
Contributor

Closing for now.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Development

No branches or pull requests

3 participants