Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure.Management.KeyVault.KeyVaultManagementClientOptions does not follow guidelines #12332

Closed
heaths opened this issue May 28, 2020 · 3 comments
Assignees
Labels
KeyVault Mgmt This issue is related to a management-plane library.

Comments

@heaths
Copy link
Member

heaths commented May 28, 2020

ClientOptions classes should have a ServiceVersion, according to https://azure.github.io/azure-sdk/dotnet_introduction.html#dotnet-versioning. This appears to be some of the reason that tests are failing, as noted in #12211

/cc @allenjzhang @pakrym @MiYanni @KrzysztofCwalina

@heaths heaths added KeyVault Mgmt This issue is related to a management-plane library. labels May 28, 2020
@erich-wang
Copy link
Member

@heaths , having no ServiceVesrion is known issue for mgmt plane as the different entity clients may use different API versions within same RP, current workaround is to disable the warning AZC0008 in project, we plan to address it after public preview.

I doubt it has something to do with #12211, will discuss detail in #12211.

@allenjzhang
Copy link
Member

allenjzhang commented Aug 7, 2020

Added to backlog AB#4034

@jsquire
Copy link
Member

jsquire commented Jun 15, 2022

Given the age of this and the shift to the track 2 packages, closing this out as stale. Please feel free to reopen if this is still needed.

@jsquire jsquire closed this as completed Jun 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
KeyVault Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

4 participants