Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Security.KeyVault.Certificates Readme issues #14529

Closed
Tianyun-G opened this issue Aug 25, 2020 · 2 comments
Closed

Azure.Security.KeyVault.Certificates Readme issues #14529

Tianyun-G opened this issue Aug 25, 2020 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass

Comments

@Tianyun-G
Copy link
Contributor

Section link

image

Reason:
1."CONTRIBUTING.md" should be a hyperlink.

Suggestion:
1.Update to [CONTRIBUTING.md][contributing].
And Add:
[contributing]: https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/keyvault/CONTRIBUTING.md

2.Add hyperlink for Conduct FAQ https://opensource.microsoft.com/codeofconduct/faq/

@jongio for notification
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 25, 2020
@tzhanl tzhanl added Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass labels Aug 25, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 25, 2020
@AlexGhiondea
Copy link
Contributor

@tzhanl could you submit a PR for this?

@Tianyun-G Tianyun-G mentioned this issue Sep 3, 2020
Merged
@Tianyun-G
Copy link
Contributor Author

PR merged.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexGhiondea @tzhanl @Tianyun-G