Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include comment with ApiCompatVersion #18995

Closed
JoshLove-msft opened this issue Feb 24, 2021 · 1 comment · Fixed by #19015
Closed

Include comment with ApiCompatVersion #18995

JoshLove-msft opened this issue Feb 24, 2021 · 1 comment · Fixed by #19015
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@JoshLove-msft
Copy link
Member

The ApiCompatVersion is automatically set to the last GA version by our bots after release. Can we include a comment in the csproj that indicates the value does not need to be manually changed?

/cc @weshaggard

@JoshLove-msft JoshLove-msft added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Feb 24, 2021
@weshaggard
Copy link
Member

Are you seeing folks trying to manually update it? Can you point at an instance?

Sure we could have the script add a comment. Feel free to update the script https://github.com/Azure/azure-sdk-for-net/blob/master/eng/scripts/Update-PkgVersion.ps1#L94 to add that comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants