Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache ACR Refresh Token in ACR Auth Policy #20330

Closed
2 tasks done
annelo-msft opened this issue Apr 13, 2021 · 1 comment
Closed
2 tasks done

Cache ACR Refresh Token in ACR Auth Policy #20330

annelo-msft opened this issue Apr 13, 2021 · 1 comment
Assignees
@annelo-msft
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Milestone
[2021] May

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Apr 13, 2021 •
edited
Loading

Per the Java auth implementation here, Java is not inheriting from their challenge auth policy in core because the cache in that policy only holds AAD access tokens.

  • Investigate whether the challenge-based auth policy in core can be extended to accomodate the ACR refresh token as well
  • Depending on the outcome of the investigation, reimplement the .NET ACR auth policy to cache the ACR refresh token as well.
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Container Registry labels Apr 13, 2021
@annelo-msft annelo-msft added this to the [2021] May milestone Apr 13, 2021
@annelo-msft annelo-msft self-assigned this May 4, 2021
@annelo-msft
Copy link
Member Author

Fixed in #20753

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@annelo-msft annelo-msft

Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Milestone
[2021] May
Development

No branches or pull requests
1 participant
@annelo-msft