Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Remove setters from collections #20622

Closed
kinelski opened this issue Apr 23, 2021 · 0 comments · Fixed by #21452
Closed

[MetricsAdvisor] Remove setters from collections #20622

kinelski opened this issue Apr 23, 2021 · 0 comments · Fixed by #21452
Assignees
@kinelski
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2021] June

Comments

@kinelski
Copy link
Member

GetIncidentsForDetectionConfigurationOptions.DimensionsToFilter is still settable. We have decided to make them not settable for consistency with other SDK libraries, but we missed this one.

Make another pass in the whole client to check if we haven't missed any other.

Note: search for keyword "CA2227".
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Apr 23, 2021
@kinelski kinelski added this to the [2021] May milestone Apr 23, 2021
@kinelski kinelski self-assigned this Apr 23, 2021
@kinelski kinelski added the blocking-release Blocks release label Apr 23, 2021
@kinelski kinelski modified the milestones: [2021] May, [2021] June May 7, 2021
@kinelski kinelski mentioned this issue May 29, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2021] June
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Removed getters from collections kinelski/azure-sdk-for-net
1 participant
@kinelski