Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Retry-After header for Key Vault long-running operations #20667

Closed
heaths opened this issue Apr 26, 2021 · 3 comments
Closed

Check Retry-After header for Key Vault long-running operations #20667

heaths opened this issue Apr 26, 2021 · 3 comments
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] December

Comments

@heaths
Copy link
Member

heaths commented Apr 26, 2021 •
edited
Loading

Key Vault is not currently checking the Retry-After header sent for LROs. We should do that in OperationHelpers as suggested in #18958.

See PR #19105 for a likely solution.
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Apr 26, 2021
@heaths heaths added this to the Backlog milestone Apr 26, 2021
@heaths heaths self-assigned this Apr 26, 2021
@heaths heaths modified the milestones: Backlog, [2021] June, [2021] July May 6, 2021
@heaths heaths modified the milestones: [2021] July, [2021] August Jun 9, 2021
@heaths
Copy link
Member Author

heaths commented Sep 22, 2021

Pushing to November since this would have no public API impact.

@heaths
Copy link
Member Author

heaths commented Dec 1, 2021

This is now handled correctly with changes to Azure.Core.

@heaths heaths closed this as completed Dec 1, 2021
@heaths heaths mentioned this issue Dec 1, 2021
Closed
@heaths
Copy link
Member Author

heaths commented Dec 1, 2021

Confirmed with live testing.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] December
Development

No branches or pull requests
1 participant
@heaths