Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation check should do retries #23739

Closed
pakrym opened this issue Sep 1, 2021 · 4 comments · Fixed by #23792
Closed

Installation check should do retries #23739

pakrym opened this issue Sep 1, 2021 · 4 comments · Fixed by #23792
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. needs-team-triage Workflow: This issue needs the team to triage.

Comments

@pakrym
Copy link
Contributor

pakrym commented Sep 1, 2021

When multiple packages are released from the same pipeline and one depends on another Azure.Core.Experimental -> Azure.Core I tend to kick off both releases at the same time. This causes the Installation Check to fail for Azure.Core.Experimental because Azure.Core is just being published.

I think we should loop and try to restore for some time (30m?) before failing the step.

@pakrym pakrym added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Sep 1, 2021
@benbp
Copy link
Member

benbp commented Sep 3, 2021

@ckairen FYI this is related to the ordering you introduced for java. I think I like the eventual approach @pakrym is proposing here better, since it will make releases easier to kick off in the background.

I think we should see if we can find a way to determine whether there is a package we expect to be published before retrying, so we don't stall the release for no reason and make people wait. This might not be possible as I don't think agents have any way to communicate values with each other while running, and additionally I don't know of a way to have a deployment job auto-retry (e.g. schedule to a new agent which would pick up a new variable context).

@benbp benbp added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Sep 3, 2021
@benbp
Copy link
Member

benbp commented Sep 3, 2021

@pakrym I'm marking this needs-triage just so it comes across for @kurtzeborn, @weshaggard and I in our weekly triage.

@jsquire jsquire added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. needs-team-triage Workflow: This issue needs the team to triage. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 3, 2021
@jsquire
Copy link
Member

jsquire commented Sep 3, 2021

Adjusting tags so that the reports don't yell at me.

@weshaggard
Copy link
Member

@benbp is a retry loop similar to what @ckairen did in python enough here, so retry in the install check and not the full job.

@ckairen ckairen linked a pull request Sep 3, 2021 that will close this issue
11 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. needs-team-triage Workflow: This issue needs the team to triage.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants