Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should project name and deployment name be treated as secrets? #24788

Closed
maririos opened this issue Oct 18, 2021 · 1 comment
Closed

Should project name and deployment name be treated as secrets? #24788

maririos opened this issue Oct 18, 2021 · 1 comment
Assignees
@maririos
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Milestone
[2021] November

Comments

@maririos
Copy link
Member

maririos commented Oct 18, 2021 •
edited
Loading

Currently, they are exposed in the TestEnviroment class. Wondering if they should be secrets.
Also, should they be sanitized?
@maririos maririos added blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics labels Oct 18, 2021
@maririos maririos added this to the [2021] November milestone Oct 18, 2021
@maririos
Copy link
Member Author

No need for them to be secrets, but we should consume them as env variables and not static in the code

@maririos maririos self-assigned this Oct 25, 2021
@maririos maririos mentioned this issue Oct 25, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Milestone
[2021] November
Development

No branches or pull requests
1 participant
@maririos