Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try async analyzer on Azure SDK common patterns #24900

Closed
pakrym opened this issue Oct 25, 2021 · 3 comments
Closed

Try async analyzer on Azure SDK common patterns #24900

pakrym opened this issue Oct 25, 2021 · 3 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative.

Comments

@pakrym
Copy link
Contributor

pakrym commented Oct 25, 2021

See dotnet/roslyn-analyzers#5367

@pakrym pakrym added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Oct 25, 2021
@pakrym pakrym self-assigned this Oct 25, 2021
@pakrym pakrym removed their assignment Jan 25, 2022
@jsquire
Copy link
Member

jsquire commented Aug 8, 2023

Rule is not enabled by default in .NET 7. (docs)

According to the docs, this does not seem like it would play well with the sync/async patterns in the Azure SDK, given that we generally run both paths through a common method and control with a conditional:

It's safe to suppress a warning from this rule in the case where there are two separate code paths for sync and async code, using an if condition. Also if there is a check for whether the Task has resolved, it is safe to use sync methods and properties

@annelo-msft annelo-msft added the MQ This issue is part of a "milestone of quality" initiative. label Sep 1, 2023
Copy link

github-actions bot commented Mar 4, 2024

Hi @pakrym, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

1 similar comment
Copy link

github-actions bot commented Apr 5, 2024

Hi @pakrym, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative.
Projects
None yet
Development

No branches or pull requests

3 participants