Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientModel: Use BinaryData.Empty instead of bespoke solution #41034

Closed
annelo-msft opened this issue Jan 5, 2024 · 1 comment · Fixed by #46669
Closed

ClientModel: Use BinaryData.Empty instead of bespoke solution #41034

annelo-msft opened this issue Jan 5, 2024 · 1 comment · Fixed by #46669
Assignees
@annelo-msft
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. CoreDi 🚀 🔮 System.ClientModel Base Core library
Milestone
Backlog

Comments

@annelo-msft
Copy link
Member

See PR comment: #41016 (comment)

This will involve:

  • Upgrading to System.Memory.Data 6.0.0 or higher
  • Upgrading to System.Text.Json 6.0.0, which System.Memory.Data brings as a dependency
  • Checking with PowerShell and Functions to ensure we don't upgrade above a version that they're using
@annelo-msft annelo-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core CoreDi 🚀 🔮 System.ClientModel Base Core library labels Jan 5, 2024
@annelo-msft annelo-msft added this to the 2024-02 milestone Jan 5, 2024
@annelo-msft annelo-msft self-assigned this Jan 5, 2024
@annelo-msft annelo-msft mentioned this issue Jan 5, 2024
Merged
@annelo-msft annelo-msft modified the milestones: 2024-02, Backlog Jan 23, 2024
@m-redding
Copy link
Member

This should be unblocked by #46134

@m-redding m-redding mentioned this issue Sep 25, 2024
Open
5 tasks
@annelo-msft annelo-msft mentioned this issue Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annelo-msft annelo-msft

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. CoreDi 🚀 🔮 System.ClientModel Base Core library
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Use BinaryData.Empty instead of bespoke solution in SCM and Azure.Core annelo-msft/azure-sdk-for-net
2 participants
@annelo-msft @m-redding