Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] consider making Azure.Core.Utf8RequestContent public #43809

Closed
cataggar opened this issue May 1, 2024 · 8 comments
Closed

[FEATURE REQ] consider making Azure.Core.Utf8RequestContent public #43809

cataggar opened this issue May 1, 2024 · 8 comments
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Milestone

Comments

@cataggar
Copy link
Member

cataggar commented May 1, 2024

Library name

Azure.Core

Please describe the feature.

In March, Utf8JsonRequestContent.cs was duplicated many many times in this PR because it is internal in Azure.Core. Before this PR, it was in the Autorest shared code. I too need to duplicate it in our internal code. Please consider making it public.

Related issues:

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 1, 2024
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Azure.Core and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels May 2, 2024
@jsquire
Copy link
Member

jsquire commented May 2, 2024

Hi @cataggar. Thanks for reaching out and for your suggestion. We'll take this under advisement and provide an update when a decision has been reached.

@jsquire
Copy link
Member

jsquire commented May 2, 2024

//cc: @annelo-msft

@annelo-msft
Copy link
Member

@cataggar - yes. We are tracking the migration of shared source types to public types with #43760. This specific one will likely look different as we proceed with that migration work as we now have a content-writing story centered around the ModelReaderWriter types in System.ClientModel. Thanks for flagging this one and keep an eye on that issue to track progress in this space. Thanks!

@jsquire jsquire added this to the Backlog milestone May 3, 2024
@annelo-msft
Copy link
Member

@cataggar, would you be willing to share the specific use case you have that motivates your need for this feature? Thanks!

@annelo-msft annelo-msft added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Oct 16, 2024
Copy link

Hi @cataggar. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

Copy link

Hi @cataggar, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Oct 23, 2024
@cataggar
Copy link
Member Author

I'll be upgrading our internal client in November, so I expect to get back to this then.

@github-actions github-actions bot added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-author-feedback Workflow: More information is needed from author to address the issue. no-recent-activity There has been no recent activity on this issue. labels Oct 30, 2024
@cataggar
Copy link
Member Author

I'm working on this internal pull request.. After some digging, it looks like my primary use case for Utf8RequestContent is a workaround for:

I'm going to check to see if I can remove the workaround now that it is fixed with:

@cataggar cataggar closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team
Projects
None yet
Development

No branches or pull requests

4 participants