Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Set client LocationIP field by default when using Azure.Monitor.OpenTelemetry.AspNetCore #44687

Open
vishweshbankwar opened this issue Jun 21, 2024 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Distro Monitor OpenTelemetry Distro needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@vishweshbankwar
Copy link
Contributor

Library name

Azure.Monitor.OpenTelemetry.AspNetCore

Please describe the feature.

Related to: #42850

When using Application Insights SDK, the location IP field is set by default. When using Azure.Monitor.OpenTelemetry.AspNetCore, users need to enable this collection by setting client.address attribute on the activity using Enrich or processor. https://learn.microsoft.com/en-us/azure/azure-monitor/app/opentelemetry-add-modify?tabs=aspnetcore#set-the-user-ip.

Opening this issue to enable the collection of LocationIP by default when using Azure.Monitor.OpenTelemetry.AspNetCore

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. labels Jun 21, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @cijothomas @rajkumar-rangaraj @reyang @TimothyMothra @vishweshbankwar.

@DrEsteban
Copy link

@vishweshbankwar @onionhammer I've logged an issue on the underlying OpenTelemetry.Instrumentation.AspNetCore SDK since that's where the root cause lies: open-telemetry/opentelemetry-dotnet-contrib#2231

While it's true this could be worked-around by the AzureMonitor distro, I agree with the assessment on #42850 that it's probably ideal if it were fixed in the underlying SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Monitor - Distro Monitor OpenTelemetry Distro needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

2 participants