Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Synonym Map creation should return a model #11514

Closed
bryevdv opened this issue May 18, 2020 · 1 comment
Closed

Search Synonym Map creation should return a model #11514

bryevdv opened this issue May 18, 2020 · 1 comment
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Milestone
[2020] June

Comments

@bryevdv
Copy link
Contributor

bryevdv commented May 18, 2020

Following the experience with Cosmos SDK, the early methods such as synonym maps creation were made to return dicts, not models. However from the UX study it is clear that returning a model would be preferable, e.g. so that syn_map.name is easily discoverable.

cc @xiangyan99 @heaths
@bryevdv bryevdv added Search Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release labels May 18, 2020
@xiangyan99 xiangyan99 mentioned this issue May 21, 2020
Merged
@AlexGhiondea AlexGhiondea added this to the [2020] June milestone May 21, 2020
@xiangyan99
Copy link
Member

Fixed in #11590

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Search
Projects
None yet
Milestone
[2020] June
Development

No branches or pull requests
3 participants
@bryevdv @AlexGhiondea @xiangyan99