Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] Update async methods to return AsyncLROPoller and support continuation token #11530

Closed
kristapratico opened this issue May 19, 2020 · 0 comments · Fixed by #11650
Closed

[formrecognizer] Update async methods to return AsyncLROPoller and support continuation token #11530

kristapratico opened this issue May 19, 2020 · 0 comments · Fixed by #11650
Assignees
@kristapratico
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Milestone
[2020] June

Comments

@kristapratico
Copy link
Member

kristapratico commented May 19, 2020 •
edited
Loading

Currently waiting on:

  1. PR for azure-core: LRO continuation_token #10801
  2. Work from autorest to support this, which is pending.

This will allow us to return AsyncLROPoller for our async methods and support continuation tokens. Because of the change in return type we will do a re-naming to align with other languages (feel free to spin-off on a different issue):

  • sync method begin_train_model -> begin_training
  • async method train_model -> begin_training
  • all async methods will now have begin prefix added to them
@kristapratico kristapratico added Cognitive Services Client This issue points to a problem in the data-plane of the library. FormRecognizer labels May 19, 2020
@kristapratico kristapratico self-assigned this May 19, 2020
@kristapratico kristapratico mentioned this issue May 27, 2020
Merged
7 tasks
@kristapratico kristapratico added this to the [2020] June milestone May 27, 2020
@kristapratico kristapratico changed the title [formrecognizer] Update async methods to return AsyncLROPoller [formrecognizer] Update async methods to return AsyncLROPoller and support continuation token May 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kristapratico kristapratico

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
[2020] June
2 participants
@kaerm @kristapratico