Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On pickle serialization, HttpResponse should whitelist the exact context to save #11686

Closed
lmazuel opened this issue May 28, 2020 · 0 comments · Fixed by #11688
Closed

On pickle serialization, HttpResponse should whitelist the exact context to save #11686

lmazuel opened this issue May 28, 2020 · 0 comments · Fixed by #11688
Assignees
@lmazuel
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone
[2020] June

Comments

@lmazuel
Copy link
Member

lmazuel commented May 28, 2020

We don't control if the context values are pickable or not, we shall start with an actual whitelist that contains the deserialized body (RawDeserializer work), and skip the rest, and extend from there.

Need to be done for the 1.6.0 cycle
@lmazuel lmazuel added Client This issue points to a problem in the data-plane of the library. Azure.Core labels May 28, 2020
@lmazuel lmazuel added this to the [2020] June milestone May 28, 2020
@lmazuel lmazuel self-assigned this May 28, 2020
@kristapratico kristapratico mentioned this issue May 28, 2020
Merged
7 tasks
@lmazuel lmazuel mentioned this issue May 28, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lmazuel lmazuel

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2020] June
Development

Successfully merging a pull request may close this issue.

Whitelist what pickle is serializing in context Azure/azure-sdk-for-python
1 participant
@lmazuel