Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EngSys] SubRecProcessor should process response URLs the same way it processes request URLs #18737

Closed
seankane-msft opened this issue May 13, 2021 · 0 comments · Fixed by #18758
Assignees
Labels
EngSys This issue is impacting the engineering system.

Comments

@seankane-msft
Copy link
Member

"I wouldn't add the regex to GeneralNameReplacer, or register_name_pair to SubscriptionRecordingProcessor. I'd just have SubscriptionRecordingProcessor process response URLs the same way it processes request URLs. GeneralNameReplacer can already do what's needed, if you register a subscription as something to replace, meaning existing libraries relying on SubscriptionRecordingProcessor's implicit behavior would have to explicitly configure GeneralNameReplacer instead"

@seankane-msft seankane-msft added the EngSys This issue is impacting the engineering system. label May 13, 2021
@seankane-msft seankane-msft self-assigned this May 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant