Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

outdated #20939

Closed
gfranxman opened this issue Sep 29, 2021 · 5 comments
Closed

outdated #20939

gfranxman opened this issue Sep 29, 2021 · 5 comments
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Data Factory Docs needs-author-feedback Workflow: More information is needed from author to address the issue. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team no-recent-activity There has been no recent activity on this issue. Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@gfranxman
Copy link

It looks like the example no longer works because the DataFactoryManagementClient libraries have changed over to use the azure.identity package.

Rather than

import from azure.common.credentials import ServicePrincipalCredentials
...
credentials = ServicePrincipalCredentials(client_id=APPLICATION_CLIENT_ID, secret=CLIENT_SECRET, tenant=TENANT_ID)

try

from azure.identity import ClientSecretCredential
...
credentials = ClientSecretCredential(tenant_id=TENANT_ID, client_id=APPLICATION_CLIENT_ID, client_secret=CLIENT_SECRET )

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Sep 29, 2021
@xiangyan99 xiangyan99 added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Data Factory Docs Service Attention Workflow: This issue is responsible by Azure service team. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 29, 2021
@ghost ghost added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 29, 2021
@ghost
Copy link

ghost commented Sep 29, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @shawnxzq, @lmy269, @Jingshu923.

Issue Details

It looks like the example no longer works because the DataFactoryManagementClient libraries have changed over to use the azure.identity package.

Rather than

import from azure.common.credentials import ServicePrincipalCredentials
...
credentials = ServicePrincipalCredentials(client_id=APPLICATION_CLIENT_ID, secret=CLIENT_SECRET, tenant=TENANT_ID)

try

from azure.identity import ClientSecretCredential
...
credentials = ClientSecretCredential(tenant_id=TENANT_ID, client_id=APPLICATION_CLIENT_ID, client_secret=CLIENT_SECRET )

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Author: gfranxman
Assignees: -
Labels:

bug, Docs, Data Factory, Service Attention, Client, customer-reported
Milestone: -

@xiangyan99
Copy link
Member

Thanks for the feedback, we’ll investigate asap.

@shawnxzq
Copy link
Member

@gfranxman which document do you follow and see the issues? Thanks!

@shawnxzq
Copy link
Member

shawnxzq commented Nov 8, 2021

@gfranxman Could you please share the doc link you are refer to? Thanks a lot!

@xiangyan99 xiangyan99 added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Dec 3, 2021
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Dec 11, 2021
@ghost
Copy link

ghost commented Dec 11, 2021

Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

@ghost ghost closed this as completed Dec 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Data Factory Docs needs-author-feedback Workflow: More information is needed from author to address the issue. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team no-recent-activity There has been no recent activity on this issue. Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gfranxman @shawnxzq @xiangyan99