Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Ensure crypto operations work as expected for all API versions #21005

Closed
mccoyp opened this issue Oct 1, 2021 · 2 comments
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault MQ This issue is part of a "milestone of quality" initiative.
Milestone

Comments

@mccoyp
Copy link
Member

mccoyp commented Oct 1, 2021

Context: the generated KeyOperationResult class only has iv, authentication_tag, and additional_authenticated_data attributes in API versions 7.2+. This isn't usually an issue, since most or all algorithms using these values require symmetric keys -- these can only be used with Managed HSM for now, which only supports API versions 7.2+.

However, some crypto operations that use some of these attributes (AES-CBCPAD, for example) can be performed locally. It's possible that someone would -- for whatever reason -- create a CryptographyClient with an earlier API version than 7.2 and attempt to perform crypto operations that use these attributes. That may not work since the generated models loaded by the CryptographyClient may not have support for the attributes.

To fix this, if it is a problem (which I have reason to think it is), we'll probably want to add a check before performing certain crypto operations -- either when we check that an algorithm is supported by our local crypto provider, or inside the encrypt/decrypt/etc. method.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Oct 1, 2021
@mccoyp mccoyp added this to the [2021] November milestone Oct 1, 2021
@mccoyp mccoyp self-assigned this Oct 1, 2021
@YalinLi0312 YalinLi0312 assigned YalinLi0312 and unassigned mccoyp Oct 19, 2021
@mccoyp mccoyp modified the milestones: [2022] March, Backlog Mar 2, 2022
@mccoyp mccoyp assigned mccoyp and unassigned YalinLi0312 Feb 1, 2024
@mccoyp mccoyp added the MQ This issue is part of a "milestone of quality" initiative. label Feb 1, 2024
Copy link

Hi @mccoyp, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
@mccoyp
Copy link
Member Author

mccoyp commented Mar 15, 2024

We can leave this closed since our generated code structure has since changed (we only generate code for the latest API version).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault MQ This issue is part of a "milestone of quality" initiative.
Projects
Archived in project
Development

No branches or pull requests

2 participants