Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket async implementation must use pure async lib when available #24315

Closed
rakshith91 opened this issue May 5, 2022 · 3 comments
Closed
Assignees
Labels
AMQP Python Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew
Milestone

Comments

@rakshith91
Copy link
Contributor

Currently, we use websocket-client library which does not have a pure async implementation

websockets has one, but it does not support http proxy python-websockets/websockets#364

When possible use a pure async library

@rakshith91 rakshith91 added Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew AMQP Python labels May 5, 2022
@rakshith91 rakshith91 added this to the Backlog milestone May 5, 2022
@hansmbakker
Copy link

aiohttp.ClientSession.ws_connect with aiohttp.ClientWebSocketResponse works quite well.

It has support for async, proxy, ssl settings, etc.

@annatisch
Copy link
Member

Thanks for this input @hansmbakker!
FYI @l0lawrence, @kashifkhan, @swathipil - we should look at this soon as we will need an async story for EH before GA.

@kashifkhan
Copy link
Member

Thank you very much @hansmbakker for sharing about the websocket client in aiohttp , this worked out perfectly for us :)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AMQP Python Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew
Projects
None yet
Development

No branches or pull requests

4 participants