Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] migrate tests from preparer to arm template #27788

Closed
swathipil opened this issue Dec 2, 2022 · 4 comments
Closed

[ServiceBus] migrate tests from preparer to arm template #27788

swathipil opened this issue Dec 2, 2022 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew MQ This issue is part of a "milestone of quality" initiative. Service Bus

Comments

@swathipil
Copy link
Member

Need to move ServiceBus tests over to using the EnvVariableLoader + ARM template to create resources. Currently we're using the ServiceBusPreparer file.

Should hopefully not run into any issues when enabling SB livetests on the sovereign cloud after this: #20517

@swathipil swathipil added Service Bus Client This issue points to a problem in the data-plane of the library. MQ This issue is part of a "milestone of quality" initiative. Messaging Messaging crew labels Dec 2, 2022
@swathipil swathipil self-assigned this Dec 2, 2022
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 2, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:CategoryLabels: 'Mgmt:0.5709719,Client:0.42363626,Service:0.004181696'

@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 2, 2022
@swathipil
Copy link
Member Author

After discussing with other languages + internally, we realized that for both Event Hubs and Service Bus, we want to create a new resource for each test, since the state of the entities should be new/not populated. We will be keeping preparers. If in the future, there is infra for creating new resources per test using an ARM template, can re-open this issue.

@swathipil swathipil reopened this May 9, 2023
@swathipil
Copy link
Member Author

Look into using azure-mgmt-resource and deployment.deploy() decorator to deploy an arm template per test. azure-mgmt-resource is more stable than azure-mgmt-servicebus, which can then be removed from dev_requirements.txt. If not, try using the admin client.

Copy link

github-actions bot commented Dec 2, 2024

Hi @swathipil, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew MQ This issue is part of a "milestone of quality" initiative. Service Bus
Projects
None yet
Development

No branches or pull requests

2 participants