Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product names out of date #29022

Closed
dcurwin opened this issue Feb 27, 2023 · 8 comments
Closed

product names out of date #29022

dcurwin opened this issue Feb 27, 2023 · 8 comments
Assignees
Labels
Docs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. Security

Comments

@dcurwin
Copy link

dcurwin commented Feb 27, 2023

The section mentioning product names has out of date product names.

It states: The name of the product which published this alert (Azure Security Center, Azure ATP, Microsoft Defender ATP, O365 ATP, MCAS, and so on).

These are the correct names:

Azure Security Center -> Microsoft Sentinel
Azure ATP -> Microsoft Defender for Identity
Microsoft Defender ATP -> Microsoft Defender for Endpoint
O365 ATP -> Microsoft Defender for Office
MCAS -> Microsoft Defender for Cloud Apps


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 27, 2023
@xiangyan99 xiangyan99 added Docs Security Mgmt This issue is related to a management-plane library. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 27, 2023
@msyyc
Copy link
Member

msyyc commented Feb 28, 2023

Hi @dcurwin, azure-mgmt-security is generated with swagger. If you want to change the description, please make an PR to update swagger definition. After your PR merged, we can release a new version for SDK then the doc will be updated automatically.

@dcurwin
Copy link
Author

dcurwin commented Feb 28, 2023

@msyyc - It is unclear how I should make that PR. Perhaps, since you're more familiar with the process, you could submit it? If not, please provide clear and specific instructions.

@msyyc
Copy link
Member

msyyc commented Mar 1, 2023

@dcurwin
Copy link
Author

dcurwin commented Mar 1, 2023

@msyyc - That is definitely not the "clear and specific instructions" I mentioned above. Once again, I request that you either submit the PR, or explain how I should make the relevant PR.

cc: @ArthurMa1978

@msyyc
Copy link
Member

msyyc commented Mar 1, 2023

Thanks for your kind remind and please help review Azure/azure-rest-api-specs#22841

@dcurwin
Copy link
Author

dcurwin commented Mar 1, 2023

Thanks for your kind remind and please help review Azure/azure-rest-api-specs#22841

I reviewed and approved that PR, thanks.

@Wzb123456789 Wzb123456789 added the issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. label Mar 3, 2023
@ghost
Copy link

ghost commented Mar 3, 2023

Hi @dcurwin. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text “/unresolve” to remove the “issue-addressed” label and continue the conversation.

@ghost
Copy link

ghost commented Mar 10, 2023

Hi @dcurwin, since you haven’t asked that we “/unresolve” the issue, we’ll close this out. If you believe further discussion is needed, please add a comment “/unresolve” to reopen the issue.

@ghost ghost closed this as completed Mar 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Docs issue-addressed Workflow: The Azure SDK team believes it to be addressed and ready to close. Mgmt This issue is related to a management-plane library. Security
Projects
None yet
Development

No branches or pull requests

4 participants