Service Bus Async with Opentelemetry: receiver._add_span_request_attributes never awaited

[erewok]

• Package Name:

  • azure-servicebus = "^7.8.2"
  • azure-core-tracing-opentelemetry = "^1.0.0b9"

• Operating System: OSX/Debian Container python:3.11-slim-bullseye

• Python Version: 3.11.2

Describe the bug
Async service-bus receiver with opentelemetry enabled warns:

/my-app/.venv/lib/python3.11/site-packages/azure/servicebus/_common/utils.py:287: RuntimeWarning: coroutine 'BaseHandler._add_span_request_attributes' was never awaited
  receiver._add_span_request_attributes(receive_span)  # type: ignore  # pylint: disable=protected-access
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

To Reproduce
Steps to reproduce the behavior:

I made a gist which reproduces this: https://gist.github.com/erewok/7cf27c54673f0e6fa0265e5ef24df6ff

Expected behavior
No warnings: span-context is added as expected.

Additional context
It looks like this method is async but it's being called by this sync method.

Worth noting: the python opentelemetry implementation may be changed in the future to support async spans.

Also: sending a message does not show the same warning in the logs.

[kashifkhan]

Hi there @erewok . Thank you for the feedback, I think we had a similar issue where we addressed it but looks like another one snuck in.

[kashifkhan]

Looks like it will be taken care of by this PR #28761

[erewok]

Sounds good @kashifkhan. We can close this one and I'll look for that release. Thanks for the update.

[kashifkhan]

Ill close it once it goes out :)

[erewok]

Appreciate it. Apologies: I should have searched before opening this. I just had this feeling that the async-servicebus+otel users would be a smallish group at this point... 🤷

[kashifkhan]

@erewok no worries about that at all :)

[kashifkhan]

Hi @erewok , we released a new version of azure-servicebus yesterday with the fix for this. Thank you :)

[erewok]

Sounds good. Thanks for letting me know.