Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[breaking change detector] Useless changelog about overload API for MGMT SDK #38006

Closed
Tracked by #35515
msyyc opened this issue Oct 21, 2024 · 0 comments · Fixed by #38047
Closed
Tracked by #35515

[breaking change detector] Useless changelog about overload API for MGMT SDK #38006

msyyc opened this issue Oct 21, 2024 · 0 comments · Fixed by #38047
Assignees

Comments

@msyyc
Copy link
Member

msyyc commented Oct 21, 2024

For #38005, the generated change contains item about overload API:

- Method `ContainerGroupsOperations.begin_create_or_update` has a new overload `def begin_create_or_update(self: None, resource_group_name: str, container_group_name: str, container_group: IO[bytes], content_type: str)`
  - Method `ContainerGroupsOperations.update` has a new overload `def update(self: None, resource_group_name: str, container_group_name: str, resource: IO[bytes], content_type: str)`
  - Method `ContainersOperations.execute_command` has a new overload `def execute_command(self: None, resource_group_name: str, container_group_name: str, container_name: str, container_exec_request: IO[bytes], content_type: str)`
  - Method `ContainerGroupProfilesOperations.create_or_update` has a new overload `def create_or_update(self: None, resource_group_name: str, container_group_profile_name: str, container_group_profile: ContainerGroupProfile, content_type: str)`
  - Method `ContainerGroupProfilesOperations.create_or_update` has a new overload `def create_or_update(self: None, resource_group_name: str, container_group_profile_name: str, container_group_profile: IO[bytes], content_type: str)`
  - Method `ContainerGroupProfilesOperations.patch` has a new overload `def patch(self: None, resource_group_name: str, container_group_profile_name: str, properties: ContainerGroupProfilePatch, content_type: str)`
  - Method `ContainerGroupProfilesOperations.patch` has a new overload `def patch(self: None, resource_group_name: str, container_group_profile_name: str, properties: IO[bytes], content_type: str)`

However, MGMT SDK changelog usually don't report about overload API so we hope tool doesn't report it anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants