Inject environment variables for subprocess

[morganics]

Is your feature request related to a problem? Please describe.

Using os.environ can cause issues in azure_cli.py, e.g. cannot find the az command even when az is on the path.

Describe the solution you'd like
Inject os environment variables in to the identity module, so that we're not dependent on the global os.environ variables.

e.g. line 223 on azure_cli.py

        working_directory = get_safe_working_dir()

        kwargs: Dict[str, Any] = {
            "stderr": subprocess.PIPE,
            "stdin": subprocess.DEVNULL,
            "cwd": working_directory,
            "universal_newlines": True,
            "timeout": timeout,
            "env": dict(self._environ, AZURE_CORE_NO_COLOR="true"), # rather than using os.environ.
        }
        return subprocess.check_output(args, **kwargs)

Describe alternatives you've considered
Patching os.environ, which isn't great.

Additional context
Messy PATHs can stop the az command being found, despite shutil locating the appropriate path.

[xiangyan99]

Thanks for the feedback, we’ll investigate asap.

[pvaneck]

Interesting that shutil.which can find az, but the subprocess is unable to resolve it even when passed in os.environ. From what I understand, shutil.which also retrieves the PATH environment variable from os.environ, which is the environment that should be passed to the subprocess. Something strange must be going on with the subprocess environment. I'm not sure if this stems from our usage of cmd \c and /bin/sh -c, however I can't seem to create a reproduction of the case where shutil can find az, but the subprocess cannot.

Are you encountering the issue on Windows or a Unix-based OS?

In any case, I am testing out just using the full path of the executable found from shutil.which, and just calling that directly. This approach should hopefully resolve the issue.

[github-actions]

Hi @morganics. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

[morganics]

It's on Windows. Happy to test out when the changes land.

[pvaneck]

I believe the general issue here should be resolved in the latest release of azure-identity which includes the mentioned change: #38606

[github-actions]

Hi @morganics. Thank you for opening this issue and giving us the opportunity to assist. We believe that this has been addressed. If you feel that further discussion is needed, please add a comment with the text "/unresolve" to remove the "issue-addressed" label and continue the conversation.