Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] aiohttp is a required peer dependency, which is undocumented #38869

Open
Goldziher opened this issue Dec 13, 2024 · 1 comment
Open

[BUG] aiohttp is a required peer dependency, which is undocumented #38869

Goldziher opened this issue Dec 13, 2024 · 1 comment
Assignees
@YalinLi0312
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Document Intelligence question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@Goldziher
Copy link

Library name and version

azure-ai-documentintelligence>=1.0.0b4

Describe the bug

Running the python client without aiohttp installed as a peer dependency causes a runtime import error.

Expected behavior

aiohttp is installed as a required dependency by the library, which doesn't cause a runtime error

Actual behavior

runtime error

Reproduction Steps

install the library in a new venv without installing aiohttp explicitly. use the library to call the api.

enjoy

Environment

MacOS
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Dec 13, 2024
@jsquire jsquire transferred this issue from Azure/azure-sdk-for-net Dec 13, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 16, 2024
@pvaneck
Copy link
Member

pvaneck commented Dec 16, 2024

Hey, thanks for the feedback.

@YalinLi0312 seems reasonable to update the library README and samples README to mention that in order to use async clients, an async transport library (e.g. aiohttp) should be installed as well. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YalinLi0312 YalinLi0312

Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Document Intelligence question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pvaneck @YalinLi0312 @Goldziher