Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-cognitiveservices-nspkg has not been converted to implicit namespaces (PEP 420) #4461

Closed
glaubitz opened this issue Mar 1, 2019 · 3 comments
Assignees

Comments

@glaubitz
Copy link

glaubitz commented Mar 1, 2019

I am currently working on updating the Python Azure SDK in openSUSE/SLE to the latest upstream version. This involves switching over the packaging to adopt to the move to implicit namespace packages (PEP 420).

This has worked fine with azure-nspkg and azure-mgmt-nspkg so far, but azure-cognitiveservices-nspkg still behaves like the old namespace packages compiles and installs the __init__.py files.

Thus, the RPM builds complains that the namespace directories are not empty as they should after switching to implicit namespace packages for Python 3.7:

[    6s] error: Installed (but unpackaged) file(s) found:
[    6s]    /usr/lib/python3.7/site-packages/azure/cognitiveservices/__init__.py
[    6s]    /usr/lib/python3.7/site-packages/azure/cognitiveservices/__pycache__/__init__.cpython-37.opt-1.pyc
[    6s]    /usr/lib/python3.7/site-packages/azure/cognitiveservices/__pycache__/__init__.cpython-37.pyc
[    6s] 
[    6s] 
[    6s] RPM build errors:
[    6s]     Installed (but unpackaged) file(s) found:
[    6s]    /usr/lib/python3.7/site-packages/azure/cognitiveservices/__init__.py
[    6s]    /usr/lib/python3.7/site-packages/azure/cognitiveservices/__pycache__/__init__.cpython-37.opt-1.pyc
[    6s]    /usr/lib/python3.7/site-packages/azure/cognitiveservices/__pycache__/__init__.cpython-37.pyc
@lmazuel
Copy link
Member

lmazuel commented Mar 1, 2019

Hi @glaubitz
You're right, I'm on it. Thanks for the report!

@lmazuel
Copy link
Member

lmazuel commented Mar 1, 2019

All of them will be released in a few minutes as 3.0.1, please re-open an issue if I missed something about it.
Thanks!

@glaubitz
Copy link
Author

glaubitz commented Mar 2, 2019

Thanks. I'll pull the updates on Monday and see if I can update all packages then. If I find something, I'll let you know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants