Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create EngSys scripting guidelines #3473

Closed
benbp opened this issue Jun 20, 2022 · 1 comment · Fixed by #3582
Closed

Create EngSys scripting guidelines #3473

benbp opened this issue Jun 20, 2022 · 1 comment · Fixed by #3582
Assignees
@benbp
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@benbp
Copy link
Member

benbp commented Jun 20, 2022 •
edited by kurtzeborn
Loading

This came up in the branch deletion post-mortem. Examples of things that would be listed in the guidelines:

  • Plumb in default -WhatIf support to all scripts
  • Improve logging more generally across our current scripts of actions taken
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 20, 2022
@kurtzeborn kurtzeborn changed the title Add/require -WhatIf support for all engsys scripts and improve logging of actions taken Create EngSys scripting guidelines Jun 20, 2022
@benbp benbp mentioned this issue Jun 20, 2022
Open
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jun 20, 2022
@kurtzeborn
Copy link
Member

We already have some EngSys scripting guidelines here. Maybe these should be broken out into a separate document and updated to include these new suggestions.

@kurtzeborn kurtzeborn mentioned this issue Jun 20, 2022
Open
6 tasks
@benbp benbp mentioned this issue Jul 6, 2022
Merged
@benbp benbp moved this from Triage to Dev in Azure SDK EngSys 🚢🎉 Jul 6, 2022
Repository owner moved this from 🐝 Dev to 🎊Closed in Azure SDK EngSys 🚢🎉 Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add powershell coding guidelines benbp/azure-sdk-tools
2 participants
@benbp @kurtzeborn