Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API PR pipeline should build and store OpenAPI from TypeSpec #3573

Open
mikekistler opened this issue Jul 6, 2022 · 7 comments
Open
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. feature-request This issue requires a new behavior in the product in order be resolved. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@mikekistler
Copy link
Member

The REST API Pipeline should run the Cadl compiler to generate the OpenAPI for a service team's Cadl file and add these files to the PR automatically.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 6, 2022
@weshaggard weshaggard added the Spec PR Tools Tooling that runs in azure-rest-api-specs repo. label Jul 6, 2022
@raych1 raych1 removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 12, 2022
@raych1 raych1 moved this to Todo in Spec PR Tools Jul 12, 2022
@raych1 raych1 assigned raych1 and unassigned jianyexi Jul 12, 2022
@raych1 raych1 moved this from Todo to Backlog in Spec PR Tools Oct 14, 2022
@raych1
Copy link
Member

raych1 commented Oct 14, 2022

Moved this item to backlog as it's not urgent.

@mikekistler
Copy link
Member Author

Need to wait for directory structure, etc. topics to settle before we can do this.

@raych1
Copy link
Member

raych1 commented Jan 3, 2023

Starting from API spec pipeline to support swagger auto generation from CADL.

@raych1
Copy link
Member

raych1 commented Jan 30, 2023

Hold off this task as the swagger example needs to be considered as part of this automation effort because example is requried along with swagger when check specs into azure rest api spec repo.

CADL doesn't support native example so it uses swagger example instead. Swagger example can be automatically generated by oav tool but every time of generation the radom string generated will be different which causes the value overridden. We need to either support generating fixed string value or skipping generation if example exists.

@raych1 raych1 assigned konrad-jamrozik and unassigned raych1 Mar 10, 2023
@konrad-jamrozik konrad-jamrozik added feature-request This issue requires a new behavior in the product in order be resolved. Central-EngSys This issue is owned by the Engineering System team. labels Apr 6, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Apr 6, 2023
@konrad-jamrozik
Copy link
Contributor

@mikekistler I wonder if this is still relevant. It also seems to me it might be quite a big chunk of work, judging by the description.

@mikekistler
Copy link
Member Author

This is still relevant. My understanding is that there is concern about pushing commits into PRs, but I don't understand the specifics of that concern. The azure-docs-rest-apis pipeline does add new commits to PRs, so it is clearly possible.

@konrad-jamrozik konrad-jamrozik changed the title REST API PR pipeline should build and store OpenAPI from Cadl REST API PR pipeline should build and store OpenAPI from TypeSpec May 6, 2024
@konrad-jamrozik
Copy link
Contributor

Currently we are deeply into figuring out the correct dir structure. Newest here:

@mikekistler re the concern of "do not make automation push changes to PRs automatically" - the sad truth is that many engineers have very weak grasp of how Git branching model operates, hence automation pushing commits to PRs often leads to confusion and increased support burden.

@mikeharder just FYI we have this issue on backlog since almost 2 years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. feature-request This issue requires a new behavior in the product in order be resolved. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Status: 📋 Backlog
Status: 📋 Backlog
Development

No branches or pull requests

5 participants