-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Only Diff option should show "context" #3640
Comments
@praveenkuttappan @chidozieononiwu I suspect for this to work we would need to improve the language parsers to discern in the JSON output between lines that should never be filtered out in diff view (i.e. class declarations), and the rest of lines that can be removed if they are not diffed. Would you agree? If so, did you want to make a proposal that we could implement in the parser for each language? |
That's true. APIView doesn't have full context of parent components which makes it hard to find parent context lines to show. Adding a context like Level 0, Level 1, Level2 etc to show tree structure will help us find the context and show entire context with it's siblings. |
@praveenkuttappan What would be more useful for APIView? It seems we have two different approaches:
|
|
Feedback from @KrzysztofCwalina : "The way I would address the problem is by changing "show diff only" to "show types with diffs only", i.e. if any members had diffs, the whole type with these members is shown." |
Related: #7375 |
Show Only Diff is a great option that is unfortunately totally unusable today. If shows very small slices of the full listing (just the changed members) which makes it impossible to tell what type the members are in and what other members are in the same type.
I propose that this option simply filters out all types that don't have changes, but otherwise shows full types with changes and their namespaces.
Update 6/14:
The text was updated successfully, but these errors were encountered: