Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Run static analysis" and always run static analysis #3724

Closed
kristapratico opened this issue Jul 21, 2022 · 5 comments
Closed

Remove "Run static analysis" and always run static analysis #3724

kristapratico opened this issue Jul 21, 2022 · 5 comments
Assignees
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@kristapratico
Copy link
Member

Due to #3712, I am trying to create a manual review without static analysis, but unchecking the box at creation time doesn't work.

image

APIView created that it is still running the linter: https://apiview.dev/Assemblies/Review/f654d0b58676400a9fe225b5df013d73

@tjprescott
Copy link
Member

@praveenkuttappan how does that checkbox affect the invocation of the APIView plugin? To skip static checking on pylint, you need to run it with --skip-pylint.

@JonathanGiles
Copy link
Member

JonathanGiles commented Jul 27, 2022

Just to invade here from a Java perspective - this checkbox has always bothered me because it doesn't do anything in Java - we will always run diagnostics, because, why not? I wish we had a simpler 'create review' dialog that wasn't as confusing (the number of times I've seen people click the 'Java' text at the bottom thinking that enabled them to create a Java review is....embarrassingly large). This is why I created #3016

@praveenkuttappan
Copy link
Member

I will remove this checkbox and make run analysis always for al languages. @JonathanGiles I will check if I can simplify this. But languages like JS and C++ benefit from these instructions to run pre steps required to create artifact unlike Python, Java and .Net.

@praveenkuttappan praveenkuttappan moved this from 🆕 New to 📋 Backlog in ApiView Aug 1, 2022
@JonathanGiles
Copy link
Member

@praveenkuttappan I understand the need to explain the pre-steps. I've always wondered if we should have a separate 'Help' page linked to from the top-nav bar that provides this help (then the upload dialog can just have a 'Need Help?' link on it instead)

@tjprescott tjprescott removed their assignment Oct 25, 2022
@tjprescott tjprescott changed the title [APIview][Python] unchecking "Run static analysis" during manual review creation doesn't work Remove "Run static analysis" and always run static analysis Oct 25, 2022
@tjprescott tjprescott added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. and removed Python labels Oct 25, 2022
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 31, 2022
@kurtzeborn kurtzeborn moved this to 🤔Triage in Azure SDK EngSys 🚢🎉 Oct 31, 2022
@kurtzeborn kurtzeborn moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Oct 31, 2022
@praveenkuttappan
Copy link
Member

This was already done as part of recent change to support CADL language and create review page was modified as well.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in ApiView Jan 24, 2023
@github-project-automation github-project-automation bot moved this from 📋Backlog to 🎊Closed in Azure SDK EngSys 🚢🎉 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants