-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Run static analysis" and always run static analysis #3724
Comments
@praveenkuttappan how does that checkbox affect the invocation of the APIView plugin? To skip static checking on pylint, you need to run it with |
Just to invade here from a Java perspective - this checkbox has always bothered me because it doesn't do anything in Java - we will always run diagnostics, because, why not? I wish we had a simpler 'create review' dialog that wasn't as confusing (the number of times I've seen people click the 'Java' text at the bottom thinking that enabled them to create a Java review is....embarrassingly large). This is why I created #3016 |
I will remove this checkbox and make run analysis always for al languages. @JonathanGiles I will check if I can simplify this. But languages like JS and C++ benefit from these instructions to run pre steps required to create artifact unlike Python, Java and .Net. |
@praveenkuttappan I understand the need to explain the pre-steps. I've always wondered if we should have a separate 'Help' page linked to from the top-nav bar that provides this help (then the upload dialog can just have a 'Need Help?' link on it instead) |
This was already done as part of recent change to support CADL language and create review page was modified as well. |
Due to #3712, I am trying to create a manual review without static analysis, but unchecking the box at creation time doesn't work.
APIView created that it is still running the linter: https://apiview.dev/Assemblies/Review/f654d0b58676400a9fe225b5df013d73
The text was updated successfully, but these errors were encountered: