Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple SDK libraries/packages of a language release upon 1 spec PR #4594

Open
Tracked by #5659
josefree opened this issue Nov 2, 2022 · 1 comment
Open
Tracked by #5659
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience user study - stakeholder

Comments

@josefree
Copy link
Member

josefree commented Nov 2, 2022

From: Wes Haggard
Sent: Saturday, October 29, 2022 1:34 AM
Subject: RE: Multiple SDK libraries/packages of a language release upon 1 spec PR

For data plane we have a number of services like KeyVault or Storage that have multiple SDK libraries and they often make spec changes that cross multiple of those libraries in a single spec PR. I believe the SDK automation can support this scenario without much issue but we need to make sure we are accounting for that in the PowerApp flow.

I mostly want to be explicit about what we should do in the case where a spec PR contains changes to multiple specs or if a given spec change might impact multiple SDKs. I believe we can support this scenario pretty easily but we just need to document what the expectations should be.

For example should there be 1:1 Spec PR to SDK PR? I think it makes the most sense, but I want it to be called out so we know how to handle it in the automation. Which does imply that an SDK PR could contain updates to multiple libraries (usually in the same service group) and when we do the release a given release plan could end up release multiple libraries for a given language.

Thanks,
Wes

From: Josephine Qiu
Subject: Multiple SDK libraries/packages of a language release upon 1 spec PR

Hi Wei Dong et all, I see Wes’s comment about multiple SDK libraries/packages of a language release upon 1 spec PR. I wonder SDK pipeline does support this scenario? Any concern of that?
On the other hand, Wes Haggard for this scenario, could suggest user separate specs updates into different PRs, and request each SDK library release one by one? I wonder if there is a real case, we can take a reference?

image

Regards,
Josephine Qiu

@dw511214992
Copy link
Member

it needs much changes, including both UX and backend. So, we need furthur disccusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience user study - stakeholder
Projects
Status: 🤔 Triage
Status: Backlog
Development

No branches or pull requests

4 participants