Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asset-Sync] Git tagging hangs if tag signing enabled #4720

Closed
pvaneck opened this issue Nov 16, 2022 · 2 comments · Fixed by #5047
Closed

[Asset-Sync] Git tagging hangs if tag signing enabled #4720

pvaneck opened this issue Nov 16, 2022 · 2 comments · Fixed by #5047
Assignees
Labels
Asset-Sync Any issues relating to moving test assets out of repos.

Comments

@pvaneck
Copy link
Member

pvaneck commented Nov 16, 2022

For those of us with GPG signing enabled locally for all commits/tags, the process to push a new tag hangs because a signed tag requires a tag message. So git tag will automatically open the user's editor. This causes the outer process to hang indefinitely.

After killing the process, I get:

Unhandled exception. Azure.Sdk.Tools.TestProxy.Common.Exceptions.HttpException: Invocation of "git tag python/monitor/azure-monitor-query_6cab4adc27" had a non-zero exit code -1.
StdOut: Vim: Error reading input, exiting...
Vim: Finished.

StdErr: Vim: Warning: Output is not to a terminal

error: There was a problem with the editor 'vim'.
Please supply the message using either -m or -F option.

Some workarounds/solutions could be to:

  • Include a default -m message with the git tag command so the editor does not open.
  • Include the -c tag.gpgsign=false parameter with the git tag command. To get around this issue, I had to git config --global tag.gpgsign false
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 16, 2022
@scbedd scbedd self-assigned this Nov 17, 2022
@scbedd scbedd added Asset-Sync Any issues relating to moving test assets out of repos. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Nov 17, 2022
@scbedd scbedd moved this from 🤔Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Jan 3, 2023
@github-project-automation github-project-automation bot moved this from 🐝 Dev to 🎊Closed in Azure SDK EngSys 🚢🎉 Jan 4, 2023
@scbedd scbedd moved this from 🎊Closed to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Jan 5, 2023
@kurtzeborn kurtzeborn moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Jan 5, 2023
@scbedd
Copy link
Member

scbedd commented Jan 13, 2023

Broke livetests with original PR that resolved this. Reverting and trying again.

@scbedd scbedd reopened this Jan 13, 2023
@github-project-automation github-project-automation bot moved this from 🎊Closed to 🤔Triage in Azure SDK EngSys 🚢🎉 Jan 13, 2023
@scbedd scbedd moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Jun 29, 2023
@scbedd
Copy link
Member

scbedd commented Jun 29, 2023

Resolved in #5139

@scbedd scbedd closed this as completed Jun 29, 2023
@github-project-automation github-project-automation bot moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jun 29, 2023
@scbedd scbedd moved this from 🎊 Closed to 🔬 Dev in PR in Azure SDK EngSys 🚢🎉 Jun 29, 2023
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Asset-Sync Any issues relating to moving test assets out of repos.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants