Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Input validation to APIView Upload. #5770

Closed
1 of 2 tasks
chidozieononiwu opened this issue Mar 21, 2023 · 2 comments · Fixed by #6069
Closed
1 of 2 tasks

Add Input validation to APIView Upload. #5770

chidozieononiwu opened this issue Mar 21, 2023 · 2 comments · Fixed by #6069
Assignees
@chidozieononiwu
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@chidozieononiwu
Copy link
Member

chidozieononiwu commented Mar 21, 2023 •
edited
Loading

For manual review/revision uploads, based on file extension expected be the language, we should validate the file selected and provide immediate feedback to the user rather than allowing the request to error.

Tasks
Preview Give feedback
  2. [APIView] APIRevision Upload #7747
    APIView Central-EngSys
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 21, 2023
@maririos maririos added APIView Central-EngSys This issue is owned by the Engineering System team. labels Apr 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Apr 3, 2023
@kurtzeborn kurtzeborn moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Apr 3, 2023
@kurtzeborn kurtzeborn removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 3, 2023
@mikekistler mikekistler moved this from 🆕 New to 📋 Backlog in ApiView Apr 17, 2023
@chidozieononiwu chidozieononiwu mentioned this issue Apr 28, 2023
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in ApiView May 1, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Azure SDK EngSys 🚢🎉 May 1, 2023
@chidozieononiwu chidozieononiwu mentioned this issue Jul 24, 2023
Closed
@chidozieononiwu
Copy link
Member Author

Reopening this to track client side input validation.

@chidozieononiwu
Copy link
Member Author

Handled by new APIview UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/input validation chidozieononiwu/azure-sdk-tools
3 participants
@maririos @kurtzeborn @chidozieononiwu