Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation not catching duplicate discriminator values #7041

Open
heaths opened this issue Sep 29, 2023 · 0 comments
Open

Validation not catching duplicate discriminator values #7041

heaths opened this issue Sep 29, 2023 · 0 comments
Assignees
@konrad-jamrozik
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. Swagger Issues for APIView support of Swagger TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl)

Comments

@heaths
Copy link
Member

heaths commented Sep 29, 2023

A partner found a bug in the swagger for iotcentral where the same discriminator value command was used in two different models. Seems we don't have swagger validation to catch this, or any error wasn't required to be fixed. We should also make sure that the TypeSpec compiler/linter is checking for this case as well.
@heaths heaths added Spec PR Tools Tooling that runs in azure-rest-api-specs repo. TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl) Swagger Issues for APIView support of Swagger labels Sep 29, 2023
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Nov 27, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Nov 27, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Nov 27, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. Swagger Issues for APIView support of Swagger TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl)
Projects
Azure SDK EngSys 🚢🎉
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heaths @konrad-jamrozik