Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback onboarding APEX feature #8837

Closed
maririos opened this issue Aug 14, 2024 · 10 comments
Closed

Feedback onboarding APEX feature #8837

maririos opened this issue Aug 14, 2024 · 10 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience

Comments

@maririos
Copy link
Member

maririos commented Aug 14, 2024

From the image:

image
  1. There seems to be a border shadow in this component. Could you check the properties and remove it?
  2. It is better to use aka.ms links when we can so we don't need to update the UI and do a release if the link changes. The link is https://aka.ms/azsdk/rest-api-scope (La Donna) I agree the aka link should be used.
  3. If might be better if this check box only appears if the user selects management plane -> In scope (La Donna) I agree if it would improve UI if the RPaaS checkbox only is displayed if user selects management plane as in scope.
  4. Because the UI might change according to the check box for RPaaS, what do you think about flipping management plane and data plane so that data plane is the first and then you have UI space for the second? (La Donna) Good idea, let's do it.

Scenario - already onboarded product:
image

I thought the goal here was to know if the existing SDKs are management plane or data plane. What if the wording is instead:

  • This product already has public management plane SDKs.
  • This product already has public data plane SDKs.
  • Eliminate This product has public SDKs. (La Donna) We could only show the relevant options based on the values of DataScope & MgmtScope. If the user already indicate there are no management plane REST API endpoints publicly exposed, then there would be no reason to ask if there are existing management plane SDKs.

Also, could you show me where is this updated in the work items?

From image:

image

@maririos
Copy link
Member Author

I have moved # 4 and 6 to issue #8841 and will remove it from the description of this issue, so it only states UI related feedback

@maririos
Copy link
Member Author

After reviewing PPE there are issues that are still not solved:

  • Scenario - already onboarded product: the wording needs to be updated
  • Summary view, product lifecycle is still empty
  • In that view, there also seems to be an error where the product name is showing in the wrong place:

Image

Other feedback:

  • Email template is not rendering properly. I forwarded it
  • When onboarding is done I get a window that I can't do anything about. When an informational meeting is not required, why do I get that pop up?
  • Talking about the same window, the message in orange is super confusing. What do I do with that? better to leave that for the email template that has more context:

Image

@maririos
Copy link
Member Author

I tried onboarding a new Product and got an exception. My selections:

  • Data plane: No
  • Management pane: yes
  • no PRs
  • No SDKs

Given this conditions I shoukd have got a request for an informational meeting, but that didn't happen:

Image

@ckairen
Copy link
Member

ckairen commented Aug 23, 2024

After reviewing PPE there are issues that are still not solved:

  • Scenario - already onboarded product: the wording needs to be updated

I don't think we've reached a consensus with LaDonna on this one?

  • Summary view, product lifecycle is still empty

This value is from products table, which I believe is from service tree. It's empty because the table value is not populated. other GA products can be shown successfully
image

  • In that view, there also seems to be an error where the product name is showing in the wrong place:

Image

Other feedback:

  • Email template is not rendering properly. I forwarded it

should be fixed, am waiting on republish to ppe (will update this line later)

  • When onboarding is done I get a window that I can't do anything about. When an informational meeting is not required, why do I get that pop up?

fixed

  • Talking about the same window, the message in orange is super confusing. What do I do with that? better to leave that for the email template that has more context:

Do we want to leave this for the email? or should we keep this as @ladonnaq suggested in the original issue

Image

@maririos
Copy link
Member Author

After reviewing PPE there are issues that are still not solved:

Scenario - already onboarded product: the wording needs to be updated
I don't think we've reached a consensus with LaDonna on this one?

Well, the current text doesn't read properly. If you need explicit consensus from La Donna you can ping her and provide the options I gave plus the ones you consider.
Either way, I would feel more comfortable releasing to prod with an improved wording.

@maririos
Copy link
Member Author

I tried to onboard a product that is new and got the following exception:

UpdateReleaseWorkItem.Run failed: { "error": { "code": 502, "source": "unitedstates-002.azure-apim.net", "clientRequestId": "cd27c530-3ce0-40b0-a092-6b9c51cb142d", "message": "BadGateway", "innerError": { "error": { "code": "NoResponse", "message": "The server did not receive a response from an upstream server. Request tracking id '08584768925454604995059120700CU173'." } } } }

@maririos
Copy link
Member Author

Given issue: https://dev.azure.com/azure-sdk/Release/_workitems/edit/23808
My answer for data plane was unsure. Does it make sense that the value for Data plane SDK release type = new initial SDKs ?

@maririos
Copy link
Member Author

Given issue: https://dev.azure.com/azure-sdk/Release/_workitems/edit/23810
My answer was:

  • yes data plane.
  • No management plane
  • yes existing SDKs

Why was I prompted to schedule an informational meeting?

image

@maririos maririos moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Aug 27, 2024
@ckairen
Copy link
Member

ckairen commented Aug 27, 2024

removed the "has existing sdk" option and reworded dataplane & mgmt as options

  • This product already has public management plane SDKs.
  • This product already has public data plane SDKs.
    according to consensus reached in meeiting

@ckairen
Copy link
Member

ckairen commented Aug 27, 2024

I tried to onboard a product that is new and got the following exception:

UpdateReleaseWorkItem.Run failed: { "error": { "code": 502, "source": "unitedstates-002.azure-apim.net", "clientRequestId": "cd27c530-3ce0-40b0-a092-6b9c51cb142d", "message": "BadGateway", "innerError": { "error": { "code": "NoResponse", "message": "The server did not receive a response from an upstream server. Request tracking id '08584768925454604995059120700CU173'." } } } }

the 502 was due to empty entries of "current lifescycle stage" & "target lifecycle stage", opening an issue for prompting error message for partner teams to update service tree #8893

@github-project-automation github-project-automation bot moved this from Deployed to PPE to Done in Engagement Experience Sep 11, 2024
@github-project-automation github-project-automation bot moved this from 🐝 Dev to 🎊 Closed in Azure SDK EngSys 🚢🎉 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Engagement Experience
Projects
Archived in project
Status: Done
Development

No branches or pull requests

2 participants