Moving more discovery into Get-PrPkgProperties
#9902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
commented
Feb 22, 2025
| foreach($triggerPath in $triggeringPaths) { | ||
| $resolvedRelativePath = (Join-Path $RepoRoot $triggerPath) | ||
| # utilize the various trigger paths against the targeted file here | ||
|
|
||
| if (!$triggerPath.StartsWith("/")){ | ||
| $resolvedRelativePath = (Join-Path $RepoRoot "sdk" "$($pkg.ServiceDirectory)" $triggerPath) |
There was a problem hiding this comment.
We can utilize the additional triggeringPath with the ci.yml path to grab the actual containing directory....that may be unnecessary because $pkg.ServiceDirectory is entirely reliable even for deeper ci.yml files.
|
The following pipelines have been queued for testing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is exploring if we can handle service-level changes without language-specific settings.