Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Request: Remove need for isolatedModules in tsconfig for Typescript #360

Closed
ramya-rao-a opened this issue May 9, 2019 · 1 comment
Closed

Change Request: Remove need for isolatedModules in tsconfig for Typescript #360

ramya-rao-a opened this issue May 9, 2019 · 1 comment
Assignees
@bterlson
Labels
architecture

Comments

@ramya-rao-a
Copy link
Contributor

The typescript guidelines suggest to set isolatedModules to true.
But doing this conflicts with our need to have declarations generated.

See Azure/azure-sdk-for-js#2655 (comment)

Therefore, requesting to remove this particular guideline

cc @bterlson
@ramya-rao-a ramya-rao-a mentioned this issue May 9, 2019
Closed
@adrianhall adrianhall assigned bterlson and unassigned adrianhall May 10, 2019
@bterlson
Copy link
Member

This has been removed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bterlson bterlson

Labels
architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bterlson @adrianhall @ramya-rao-a