Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Secrets created by ASO should have configurable annotations #1398

Open
matthchr opened this issue Mar 26, 2021 · 5 comments
Open

Feature: Secrets created by ASO should have configurable annotations #1398

matthchr opened this issue Mar 26, 2021 · 5 comments

Comments

@matthchr
Copy link
Member

As originally requested in #1396, @EdYa was looking for a way to allow another namespace access to the secret created by a PostgreSQLUser.

I could imagine that annotation support for secrets could be quite helpful. If we could add some annotations for kubernetes-reflector then we could mirror the secrets to the correct namespace.

An example of what this might look like:

apiVersion: azure.microsoft.com/v1alpha1
kind: PostgreSQLUser
metadata:
  name: psqluser
spec:
  server: psqlserver
  dbName: psqldb
  resourceGroup: myrg
  secretConfig:
    metadata:
      annotations:
        my-annotation: "foo"

We have other fields which are often applicable for secrets as well, such as KeyVaultToStoreSecrets. It's possible that it would make sense to move this value into this secretConfig at some point in the future as well.

@matthchr
Copy link
Member Author

We're still somewhat interested in this but there hasn't been a lot of user need yet, so going to leave this issue open and see if anybody finds it desirable.

@theunrepentantgeek
Copy link
Member

Still somewhat interested but haven't seen any demand as yet.

@matthchr
Copy link
Member Author

No change from what @theunrepentantgeek said.

@theunrepentantgeek theunrepentantgeek modified the milestones: v2.6.0, v2.7.0 Dec 11, 2023
@matthchr matthchr removed this from the v2.7.0 milestone Feb 22, 2024
@matthchr
Copy link
Member Author

Still no change from this:

Still somewhat interested but haven't seen any demand as yet.

@theunrepentantgeek
Copy link
Member

We're still interested in doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants