Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish multi-arch image manifest for controller-manager including arm64 #3321

Closed
nojnhuh opened this issue Sep 19, 2023 · 1 comment · Fixed by #3355
Closed

Publish multi-arch image manifest for controller-manager including arm64 #3321

nojnhuh opened this issue Sep 19, 2023 · 1 comment · Fixed by #3355
Assignees
Labels
high-priority Issues we intend to prioritize (security, outage, blocking bug) new-feature
Milestone

Comments

@nojnhuh
Copy link
Member

nojnhuh commented Sep 19, 2023

Describe the current behavior
ASO's official images are currently only built for linux/amd64:

% docker manifest inspect mcr.microsoft.com/k8s/azureserviceoperator:v2.3.0
{
        "schemaVersion": 2,
        "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
        "config": {
                "mediaType": "application/vnd.docker.container.image.v1+json",
                "size": 3100,
                "digest": "sha256:c21d4b8ad4a63ed679622b1c2d7adaabb5df495db340062c1e715a256d0e6481"
        },
        "layers": [
                {
                        "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                        "size": 83932,
                        "digest": "sha256:dd5ad9c9c29f04b41a0155c720cf5ccab28ef6d353f1fe17a06c579c70054f0a"
                },
                ...
        ]
}

Compared to:

% docker manifest inspect registry.k8s.io/cluster-api-azure/cluster-api-azure-controller:v1.11.0
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2403,
         "digest": "sha256:c270d77a0cd5b9b3e59037b5915f3b68ef9658df7983908516f8182a8dc4c81c",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 2403,
         "digest": "sha256:3ef1aedb72804e5391c0cc7ceb5c36c2b56cbe8cef060c377b55d7fbaea038a9",
         "platform": {
            "architecture": "arm64",
            "os": "linux",
            "variant": "v8"
         }
      },
      ...
   ]
}

Describe the improvement
ASO should also build a linux/arm64 image and publish a multi-arch manifest referenced by the Helm chart and YAML manifests.

Additional context
Add any other context about the suggested improvement.

@matthchr matthchr added this to the v2.4.0 milestone Sep 25, 2023
@matthchr matthchr added high-priority Issues we intend to prioritize (security, outage, blocking bug) and removed needs-triage 🔍 labels Sep 25, 2023
@matthchr
Copy link
Member

Thanks for calling this to our attention!

@super-harsh super-harsh self-assigned this Sep 25, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Oct 11, 2023
@matthchr matthchr moved this from Recently Completed to Ready for Release in Azure Service Operator Roadmap Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority Issues we intend to prioritize (security, outage, blocking bug) new-feature
Projects
Development

Successfully merging a pull request may close this issue.

4 participants