Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support az storage blob [upload-batch | sync] --follow-symlinks option #1303

Closed
djc opened this issue Feb 4, 2020 · 14 comments
Closed

Support az storage blob [upload-batch | sync] --follow-symlinks option #1303

djc opened this issue Feb 4, 2020 · 14 comments
Assignees

Comments

@djc
Copy link

djc commented Feb 4, 2020

Is your feature request related to a problem? Please describe.
I'm trying to update my static website from a continuous deployment process to the static website storage on Azure. The static files (CSS, images etc) live in the top of the repository, above the rest of the website contents, because they're shared with my actual project. I'd like to have a static symlink in the site directory linking to ../static dir, and for the Azure CLI to upload the files from the static dir (symlink) if I do so.

Funnily enough, the underlying azcopy command outputs a warning if I try to upload/sync my symlink, saying INFO: Skipping over symlink at /var/lib/gitlab-runner/builds/DsF6D-si/0/foo/bar/site/static because --follow-symlinks is false. However, the Azure CLI itself does not actually recognize --follow-symlinks, and will thus error out with ERROR: az: error: unrecognized arguments: --follow-symlinks.

Describe the solution you'd like
It would be great if Azure CLI recognized --follow-symlinks and propagated it to the underlying azcopy invocation.

@arrownj
Copy link

arrownj commented Feb 5, 2020

Hi @Juliehzl , could you please help take a look at this ?

@yonzhan
Copy link

yonzhan commented Feb 5, 2020

add to S166.

@yonzhan yonzhan assigned zhoxing-ms and unassigned Juliehzl Apr 18, 2020
@zhoxing-ms
Copy link

zhoxing-ms commented May 19, 2020

Hi @djc In fact, only the bottom of command az storage blob sync calls azcopy. In the case of supporting symbolic links, there is a lack of --follow-symlinks parameter. I will submit a PR to solve this problem.
Command az storage blob upload-batch on my side can support symbolic links, what's the problem with you? If there are some problems, Could you please add the --debug parameter to the original command and show me the printed information?

@djc
Copy link
Author

djc commented May 19, 2020

I can't easily test this now. In any case I don't just want to upload, I want to fully sync such that old files get removed.

@zhoxing-ms
Copy link

@djc Hi, the sync operation of azcopy is not supported --follow-symlinks, while the copy operation of azcopy is supported --follow-symlinks.
So I submitted a PR to add the --follow-symlinks parameter to the command az storage blob copy to support symbolic link. May I ask if this can meet your needs?

@djc
Copy link
Author

djc commented May 20, 2020

I really think the sync operation should be able to support following symlinks.

@Juliehzl
Copy link

@zezha-msft do you have any plan to add --follow-symlinks in sync?

@zezha-msft
Copy link
Contributor

Hi @djc, we haven't added support for symlinks in the sync command due to the lack of understanding on its intended usage. It's great that you have reached out and provided insights.

I will log this feature request in the AzCopy backlog.

@ghost
Copy link

ghost commented May 26, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@xiafu-msft xiafu-msft transferred this issue from Azure/azure-cli Jan 9, 2021
@tgalery
Copy link

tgalery commented Mar 5, 2021

Any updates on this one ? This is affecting us and it should be something relatively easy to fix. Happy to contribute as well.

@dav009
Copy link

dav009 commented Mar 8, 2021

it seems this was fixed here: Azure/azure-cli#13589

@tgalery
Copy link

tgalery commented Mar 9, 2021

@zezha-msft maybe we can close this ?

@zezha-msft
Copy link
Contributor

Thanks @tgalery @dav009 for following up on this!

@marc-hb
Copy link

marc-hb commented Nov 23, 2022

@zezha-msft do you have any plan to add --follow-symlinks in sync?

I will log this feature request in the backlog.

Looks like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants