Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShareUsageBytes is int32 #28

Open
djyou opened this issue Oct 15, 2019 · 6 comments
Open

ShareUsageBytes is int32 #28

djyou opened this issue Oct 15, 2019 · 6 comments
Assignees
Labels

Comments

@djyou
Copy link
Member

djyou commented Oct 15, 2019

Why is int32 used to represent ShareUsageBytes?

ShareUsageBytes int32 `xml:"ShareUsageBytes"`

Which version of the SDK was used?

Which platform are you using? (ex: Windows, Linux, Debian)

What problem was encountered?

How can we reproduce the problem in the simplest way?

Have you found a mitigation/solution?

@zezha-msft
Copy link
Contributor

Hi @djyou, thanks for reaching out and letting us know this problem!

That code was generated. I see it should be modified to 64 bit integer type to cover the right range of numbers.

@adreed-msft
Copy link
Member

Because I lack write access to this repo, I can't milestone this issue

@zezha-msft
Copy link
Contributor

@adreed-msft you have it now 😄

@zezha-msft
Copy link
Contributor

@mohsha-msft there's a PR here: #29

@mohsha-msft
Copy link

@adreed-msft Here is the link of build where I noticed one test case failing

@metodi123
Copy link

Hi @zezha-msft , @adreed-msft and @mohsha-msft ,

It seems like this issue is still present since the change made by @adreed-msft (#29) was reverted by @mohsha-msft (#40) because of failing tests (https://travis-ci.org/github/Azure/azure-storage-file-go/builds/724857628).

Do you plan on providing a new fix for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants