New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on file download error due to not checking returned err #55

Open

AdallomRoy opened this issue Sep 5, 2021 · 0 comments · Fixed by #56

AdallomRoy commented Sep 5, 2021

Which version of the SDK was used?

Latest

Which platform are you using? (ex: Windows, Linux, Debian)

Doesn't matter

What problem was encountered?

panic

How can we reproduce the problem in the simplest way?

See here: https://github.com/Azure/azure-storage-file-go/blob/master/azfile/highlevel.go#L183
err is not checked, so failure to download the file will cause panic as dr is nil

Have you found a mitigation/solution?

No

AdallomRoy mentioned this issue

Fix panic on download error #56

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment