Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Callback invoked to tell whether a transfer should be done." Does Microsoft mean "to check"? #31647

Closed
sijucm opened this issue Oct 7, 2022 · 4 comments · May be fixed by Azure/azure-storage-net-data-movement#299
Closed

"Callback invoked to tell whether a transfer should be done." Does Microsoft mean "to check"? #31647

sijucm opened this issue Oct 7, 2022 · 4 comments · May be fixed by Azure/azure-storage-net-data-movement#299
Assignees
@navba-MSFT
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)

Comments

@sijucm
Copy link

sijucm commented Oct 7, 2022

What does Microsoft mean by "to tell"

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 7, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Storage Storage Service (Queues, Blobs, Files) labels Oct 7, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 7, 2022
@jsquire jsquire added Service Attention Workflow: This issue is responsible by Azure service team. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team CXP Attention and removed needs-team-triage Workflow: This issue needs the team to triage. Service Attention Workflow: This issue is responsible by Azure service team. labels Oct 7, 2022
@ghost ghost added the needs-team-triage Workflow: This issue needs the team to triage. label Oct 7, 2022
@ghost
Copy link

ghost commented Oct 7, 2022

Thank you for your feedback. This has been routed to the support team for assistance.

@jsquire jsquire removed the needs-team-triage Workflow: This issue needs the team to triage. label Oct 7, 2022
@navba-MSFT navba-MSFT self-assigned this Oct 10, 2022
@navba-MSFT
Copy link
Contributor

@sijucm Apologies for the late reply. Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

navba-MSFT added a commit to navba-MSFT/azure-storage-net-data-movement that referenced this issue Oct 10, 2022
@navba-MSFT
{AzureStorage} fixes Azure/azure-sdk-for-net#31647
a486d59 
fixes Azure/azure-sdk-for-net#31647

Docs Link: https://learn.microsoft.com/en-us/dotnet/api/microsoft.azure.storage.datamovement.shouldtransfercallbackasync?view=azure-dotnet

Description needs to be updated from "Callback invoked to tell whether a transfer should be done" to "Callback invoked to check whether a transfer should be done"
@navba-MSFT navba-MSFT mentioned this issue Oct 10, 2022
Open
@navba-MSFT
Copy link
Contributor

@sijucm The above PR has been filed to address the description of this delegate and it is currently under review.

@navba-MSFT navba-MSFT removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Oct 10, 2022
@navba-MSFT
Copy link
Contributor

@sijucm I have been informed by the Product Owners that, We’re not taking any changes to this repository. We’ve already put up the deprecation notice on the README, that only changes we’re taking are security issues or data integrity issues. I understand documentation issues are important however it’s important we don’t take any changes unless they’re absolutely necessary.

To answer your question, in this article “to tell” means “to check” means you can use the ShouldTransferCallbackAsync call to check the status of the transfer.

Hope this clarifies. If you have any further further queries, please feel free to reopen this issue. We would be happy to assist you.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@navba-MSFT navba-MSFT

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

{AzureStorage} fixes Azure/azure-sdk-for-net#31647 navba-MSFT/azure-storage-net-data-movement
4 participants
@jsquire @sijucm @azure-sdk @navba-MSFT