Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data factory missing encode support for timedelta #165

Open
yunhaoling opened this issue Jul 23, 2020 · 0 comments
Open

Data factory missing encode support for timedelta #165

yunhaoling opened this issue Jul 23, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@yunhaoling
Copy link
Contributor

yunhaoling commented Jul 23, 2020

The data type datetime.timedelta is not supported in uamqp when encoding message (or its properties) leading to the failure of sending messages containing timedelta.

In .Net AMQP implementation, they support TimeSpan by a DescribedType.
https://github.com/Azure/azure-sdk-for-net/blob/94b8c933793f0801aa97d80218798894fa32d74f/sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs#L554-L555

The descriptor is com.microsoft::timespan, and the value is integer (seconds).
We should investigate whether this could be supported in uamqp.


we should support

msg = Message(body='data')
msg.application_properties = { 'some_key': timedelta(hours=1') }  # timedelta data type

SendClient.send_messages(msg)
@yunhaoling yunhaoling changed the title Data factory missing data type support Data factory missing encode support for timedelta Jul 23, 2020
@yunhaoling yunhaoling added the enhancement New feature or request label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant